Hide Forgot
Created attachment 1223242 [details] planner->notscheduled->addaction Description of problem: Planner tabs and plan frame has untranslated entries. Version-Release number of selected component (if applicable): Insightsbeta How reproducible: Always Steps to Reproduce: 1. Log into https://access.redhat.com/insightsbeta/overview/ with ja-JP locale. 2. Click on 'Planner' on left pane, tabs 'PAST', 'NOT SCHEDULED' and 'FUTURE' not translated. 3. Click on 'NOT SCHEDULED' tab and expand any plan. 'Actions' tab name not translated. 'Systems' tab name not translated. 'Add action' and 'Add system' not translated. Static strings 'Actions resolved' and 'days ago' not translated. Actual results: Translation not available Expected results: Translations should present Additional info: Screen shot references attached.
Created attachment 1223243 [details] planner->notscheduled->addsystem
I am handing over all L10N/I18N things to Jaylin (zzhou@).
I fixed most of these here: http://labs-git.usersys.redhat.com/labs/insights/commit/f38224b5b24a23af6cf05c723e787b7794b6b92f Let me know if there are some keys still missing. The only string I cannot fix is 'days ago' because that one does not come from the Insights web app but is generated by a time library that we use (timeAgo). That library does not currently support ja-JP. Would it be possible for anyone to contribute the ja-JP translation? The library is pretty minimalistic so it should be quite easy. See an example here: https://github.com/yaru22/angular-timeago/tree/master/src/languages
Hi Jozef, i have added kmoriguc to cc list and asking Michelle Kim for the input regarding your query. Hi Michelle, could you please provide your input about the feasibility of ja-JP support mentioned in Comment 3. Thanks, krishna.
Hi Krishna and Jozef, I will check with my team if we can contribute Ja translation for the time library. Will get back to you shortly once done.
Hi Jozef, Our translator helped translating the file, but not aware how to contribute the file back to the project, so I decided to attach the translated file here if you could help passing it to the timeAgo maintainer. Hope this will help resolving this bug. Thanks, Michelle
Created attachment 1225101 [details] ja-JP translation for TimeAgo library ja-JP translation for TimeAgo library
Adding new attachment as previous file had TimeAgoSettings.strings['en_US'] so new one has replaced en_US with ja_JP
Created attachment 1225102 [details] Updated ja_JP file for TimeAgo library. Please use this one
Michelle, Krishna, that's awesome! I am going to send the contribution to timeAgo library maintainers. For proper attribution, who should I specify as the author?
http://labs-git.usersys.redhat.com/labs/insights/merge_requests/319
Hi Jozef, Apologies for late reply as I was on leave. The author (translator) is Kenzo Moriguchi kmoriguc Thanks, Michelle
Verified on https://access.redhat.com/insightsbeta/planner/5825 , can not reproduce now.