Bug 1398774 - PATCH: Midori import bookmarks as exported! No sort!
Summary: PATCH: Midori import bookmarks as exported! No sort!
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: midori
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-25 22:37 UTC by Ali Akcaagac
Modified: 2018-05-29 11:30 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-29 11:30:33 UTC
Type: Bug


Attachments (Terms of Use)
No sort bookmarks importing! Keep Order! (2.76 KB, patch)
2016-11-25 22:37 UTC, Ali Akcaagac
no flags Details | Diff

Description Ali Akcaagac 2016-11-25 22:37:38 UTC
Created attachment 1224466 [details]
No sort bookmarks importing! Keep Order!

Midori imports bookmarks from other browsers as exported Netscape or XBEL format.
Unfortunately (depends on the view of the user), Midori sorts the bookmarks in an ascending and descending way, rather than keeping the ordered bookmarks as they were imported.

Even if the ORDE BY selection is removed from the bookmarks db importer, the bookmarks show up ascending from the bookmarks (toolbar button: you need to insert the bookmarks button to the toolbar (not bookmarks bar)). And the bookmarks show up descending in the side panel.

So regardles if sorted (as is) midori shows the bookmarks sorted in the bookmarks toolbar button and reverse sorted in the side panel.

The patch provided here removes the ASC/DESC ordering during importing of the bookmarks, so the bookmarks stay as they are (interchangable with firefox and/or chrome).

The patch ensures that even the toolbar bookmarks button, the bookmarks bar and the bookmarks side panel orders the bookmarks correctly as imported.

Though there is still a minor issue with removing separators that I haven't found out yet.

Sharing patch!

Comment 1 Fedora End Of Life 2017-02-28 10:39:57 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 2 Fedora End Of Life 2018-05-03 08:18:42 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2018-05-29 11:30:33 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.