Bug 1399683 - Change logic of file version checking
Summary: Change logic of file version checking
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpmlint
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-29 14:51 UTC by David Kaspar // Dee'Kej
Modified: 2017-03-02 00:49 UTC (History)
6 users (show)

Fixed In Version: rpmlint-1.9-7.fc25 rpmlint-1.9-7.fc24
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-10 14:23:00 UTC
Type: Bug


Attachments (Terms of Use)

Description David Kaspar // Dee'Kej 2016-11-29 14:51:45 UTC
Description of problem:
At the moment, rpmlint will complain (display warning) about 'unversioned-explicit-provides' for a file with absolute path. If you try to fix this by adding the %{version}, then checking again with rpmlint will lead to an error:
> specfile-error error: line 11: Versioned file name not permitted

The logic of this does not make any sense, and it should be changed, either in the code, or preferably in some default configuration of rpmlint.

rpmlint shouldnt warn that something is wrong when fix would cause an error instead...

And before we get to the discussion that specfile should not contain the 'Provides' with absolute path, I need to tell you that for some packages this is necessary (and most likely always will be). I'm taking care of tcsh, which as a shell, was always placed as /bin/tcsh. This is no longer true because of UsrMove, but we need to keep that 'Provides' in the specfile because of backwards compatibility.

As a result, I always see an unnecessary warning in Bodhi after dist.rpmlint check.

Version-Release number of selected component (if applicable):
rpmlint-1.9-3.fc24.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create a specfile containing 'Provides: /bin/tcsh = %{version}'
2. Run rplint on the specfile.

Actual results:
Misleading warning about 'unversioned-explicit-provides /bin/tcsh'

Expected results:
No warning about 'unversioned-explicit-provides /bin/tcsh'.

Comment 1 Ville Skyttä 2016-11-29 20:29:01 UTC
(In reply to David Kaspar [Dee'Kej] from comment #0)
> [...] then checking again with rpmlint will
> lead to an error:
> > specfile-error error: line 11: Versioned file name not permitted

FWIW this error comes from rpm.

> rpmlint shouldnt warn that something is wrong when fix would cause an error
> instead...

Agreed, it's probably best to stop complaining about versioned absolute-path Provides in rpmlint. Would you mind filing an upstream issue about this?
https://github.com/rpm-software-management/rpmlint

Comment 2 David Kaspar // Dee'Kej 2017-01-19 14:38:34 UTC
(In reply to Ville Skyttä from comment #1)
> Agreed, it's probably best to stop complaining about versioned absolute-path
> Provides in rpmlint. Would you mind filing an upstream issue about this?
> https://github.com/rpm-software-management/rpmlint

Done! :)

Comment 3 David Kaspar // Dee'Kej 2017-01-31 10:57:23 UTC
Upstream has fixed this issue:
https://github.com/rpm-software-management/rpmlint/issues/90

They also mention that there's an option to add our own filters into the default Fedora config - 'addFilter' to filter which we do not want to see.

Comment 4 Fedora Update System 2017-02-09 14:37:30 UTC
rpmlint-1.9-7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f341bddc4e

Comment 5 Fedora Update System 2017-02-09 14:37:42 UTC
rpmlint-1.9-7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-11eb2e80ae

Comment 6 Fedora Update System 2017-02-09 21:52:47 UTC
rpmlint-1.9-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f341bddc4e

Comment 7 Fedora Update System 2017-02-09 22:22:22 UTC
rpmlint-1.9-7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-11eb2e80ae

Comment 8 Fedora Update System 2017-02-10 14:23:00 UTC
rpmlint-1.9-7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-03-02 00:49:38 UTC
rpmlint-1.9-7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.