Hide Forgot
Description of problem: This is not a bug. Seeing rubygem-nokogiri.spec, I found something. So, I would like to inform it. That is about echo "Please investigate this" might be not needed in below code. ``` ruby \ -I.:lib:test:ext -e \ "require 'test/helper' ; Dir.glob('test/**/test_*.rb'){|f| require f}" || \ echo "Please investigate this" ``` Because the test suite is passed. ``` 1384 runs, 3973 assertions, 0 failures, 0 errors, 4 skips ``` Version-Release number of selected component (if applicable): rubygem-nokogiri-1.6.8.1-1.fc26 How reproducible: Steps to Reproduce: 1. $ git diff diff --git a/rubygem-nokogiri.spec b/rubygem-nokogiri.spec index 77e3b5f..b470c7b 100644 --- a/rubygem-nokogiri.spec +++ b/rubygem-nokogiri.spec @@ -221,8 +221,7 @@ ruby \ -I.:lib:test \ %endif -e \ - "require 'test/helper' ; Dir.glob('test/**/test_*.rb'){|f| require f}" || \ - echo "Please investigate this" + "require 'test/helper' ; Dir.glob('test/**/test_*.rb'){|f| require f}" for f in $SKIPTEST do 2. $ fedpkg scratch-build --srpm The scratch build is succeeded. http://koji.fedoraproject.org/koji/taskinfo?taskID=16672404 Additional info: Now possible {?fedora} is >= 23. I think we can also remove several "if" logic from the rubygem-nokogiri.spec file.
For now, I fixed (modified) this issue.
okay thank you!