Bug 1399795 - [RFE] HPA waits on pods being marked as Ready
Summary: [RFE] HPA waits on pods being marked as Ready
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 3.3.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Solly Ross
QA Contact: DeShuai Ma
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-29 18:32 UTC by Eric Jones
Modified: 2020-07-16 09:02 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-03 20:17:57 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Eric Jones 2016-11-29 18:32:08 UTC
- What is the nature and description of the request? 
As an developer I require the ability to not have my application scale untilafter it is ready

- Why does the customer need this? (List the business requirements here) 
They need to be able to deploy all components of an application (imagestream, service, DC/RC, HPA, etc.) at once and not have the HPA try to scale everything upbefore the application is ready.

- How would the customer like to achieve this? (List the functional requirements here) 
Have the HPA catch on the Readiness Probe of the Pod

- For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.
Deploy an app with a readiness probe and HPA and have it not scale till after the app is stable.

- Is there already an existing RFE upstream or in Red Hat Bugzilla?
Yes:
https://github.com/kubernetes/kubernetes/pull/33593

It is already supposed to be a thing in 3.4:
https://github.com/openshift/ose/blob/enterprise-3.4/vendor/k8s.io/kubernetes/pkg/controller/podautoscaler/metrics/metrics_client.go#L126

But is not in 3.3:
https://github.com/openshift/ose/blob/v3.3.1.4/vendor/k8s.io/kubernetes/pkg/controller/podautoscaler/metrics/metrics_client.go#L125

Comment 3 Solly Ross 2016-11-29 19:45:46 UTC
FYI: the linked line in 3.4 deals with pod phase (Pending / Running / etc), not pod condition (Ready / Unready).  The linked PR, which deals with Ready / Unready, is in Kubernetes 1.5, so I'll be a thing in 3.5

Comment 4 Troy Dawson 2017-01-27 17:44:56 UTC
Since this is a backport request for 3.3, and there is no pull request yet, I am putting this back to Assigned until the 3.3 backport pull request is created and added to this bug.


Note You need to log in before you can comment on or make changes to this bug.