Bug 1400947 - [abrt] system-config-printer-libs: __init__.py:118:require_version:ValueError: Namespace GnomeKeyring not available: TAINTED
Summary: [abrt] system-config-printer-libs: __init__.py:118:require_version:ValueError...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-printer
Version: 26
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zdenek Dohnal
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:2d81047e10d5860c3931ff0e915...
: 1459079 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-02 11:43 UTC by iliketurtlesbro
Modified: 2017-09-11 10:51 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-11 10:33:10 UTC
Type: ---


Attachments (Terms of Use)
File: backtrace (700 bytes, text/plain)
2016-12-02 11:43 UTC, iliketurtlesbro
no flags Details
File: environ (1.37 KB, text/plain)
2016-12-02 11:43 UTC, iliketurtlesbro
no flags Details

Description iliketurtlesbro 2016-12-02 11:43:33 UTC
Version-Release number of selected component:
system-config-printer-libs-1.5.7-10.fc26

Additional info:
reporter:       libreport-2.8.0
cmdline:        /usr/bin/python3 /usr/share/system-config-printer/scp-dbus-service.py
executable:     /usr/share/system-config-printer/scp-dbus-service.py
kernel:         4.9.0-0.rc6.git2.1.fc26.x86_64
pkg_fingerprint: 812A 6B4B 64DA B85D
pkg_vendor:     Fedora Project
runlevel:       N 5
type:           Python3
uid:            1000

Truncated backtrace:
__init__.py:118:require_version:ValueError: Namespace GnomeKeyring not available

Traceback (most recent call last):
  File "/usr/share/system-config-printer/scp-dbus-service.py", line 36, in <module>
    import jobviewer
  File "/usr/share/system-config-printer/jobviewer.py", line 57, in <module>
    gi.require_version('GnomeKeyring', '1.0')
  File "/usr/lib64/python3.5/site-packages/gi/__init__.py", line 118, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace GnomeKeyring not available

Local variables in innermost frame:
available_versions: []
version: '1.0'
namespace: 'GnomeKeyring'
repository: <gi.Repository object at 0x7fdcaa3ff6f0>

Comment 1 iliketurtlesbro 2016-12-02 11:43:39 UTC
Created attachment 1227292 [details]
File: backtrace

Comment 2 iliketurtlesbro 2016-12-02 11:43:40 UTC
Created attachment 1227293 [details]
File: environ

Comment 3 Fedora End Of Life 2017-02-28 10:43:03 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 4 sedrubal 2017-05-16 19:14:57 UTC
Similar problem has been detected:

I tried to add a printer

reporter:       libreport-2.9.1
cmdline:        /usr/bin/python3 /usr/share/system-config-printer/scp-dbus-service.py
crash_function: require_version
exception_type: ValueError
executable:     /usr/share/system-config-printer/scp-dbus-service.py
kernel:         4.11.0-2.fc26.x86_64
package:        system-config-printer-libs-1.5.9-3.fc26
reason:         __init__.py:118:require_version:ValueError: Namespace GnomeKeyring not available
runlevel:       N 5
type:           Python3
uid:            1000

Comment 5 Zdenek Dohnal 2017-05-16 19:26:34 UTC
Oh, this issue is because of libgnome-keyring is deprecated - I'm currently working on port to libsecret.

Comment 6 Michal Halenka 2017-06-06 08:57:02 UTC
*** Bug 1459079 has been marked as a duplicate of this bug. ***

Comment 7 Seth Jennings 2017-06-18 21:28:36 UTC
Similar problem has been detected:

Tried to install printer.  Brother HL-3170CDW.  Dialog says "Failed to add printer".  Printer is not added.

reporter:       libreport-2.9.1
cmdline:        /usr/bin/python3 /usr/share/system-config-printer/scp-dbus-service.py
crash_function: require_version
exception_type: ValueError
executable:     /usr/share/system-config-printer/scp-dbus-service.py
kernel:         4.11.4-300.fc26.x86_64
package:        system-config-printer-libs-1.5.9-3.fc26
reason:         __init__.py:118:require_version:ValueError: Namespace GnomeKeyring not available
runlevel:       N 5
type:           Python3
uid:            1000

Comment 8 Seth Jennings 2017-06-18 21:45:05 UTC
Related:
https://bugs.archlinux.org/task/52607

I submitted a PR upstream:
https://github.com/zdohnal/system-config-printer/pull/66

Depending on the responsiveness of upstream, we might want to carry this as a patch in the system-config-printer RPM before F26 releases.

Comment 9 Seth Jennings 2017-06-18 21:48:20 UTC
Ha! Just noticed that the upstream owner, package owner, and bug owner are all the same.  I would expect the responsiveness to be equivalent then :P

Comment 10 Zdenek Dohnal 2017-06-19 07:14:00 UTC
Hi Seth,

I know about this archlinux "fix" - but I would expect you read previous comments :) - this fix is only workaround, which turns off any storing passwords in s-c-p. Correct way to solve this issue is rewrite s-c-p with usage of libsecret (because this bug is caused by deprecated libgnome-keyring module), which I am working on now (but suddenly other cases appeared etc., so I didn't have much time to this issue).
I can push workaround into upstream and our branch, but it will turn off storing passwords.

Comment 11 Seth Jennings 2017-06-19 14:05:59 UTC
Zdenek,

Yes, I called it a workaround; it is not a fix.  However, s-c-p in F26 is currently broken.  This workaround prevents a regression.

It seems that the code in s-c-p was built with the absence of gnome keyring in mind as indicated by USE_KEYRING.  I really just added one more error type to that check such that it won't crash and result in abrt reports.

I'm not sure what role the keyring plays as, in my case at least, it works just fine without it.

Can you think you can rewrite for libsecret before F26 release?  I don't have the time or expertise to do it in the short term.

If not, I think we need this workaround in the short term.

Comment 12 Zdenek Dohnal 2017-06-19 14:38:43 UTC
Ok, I'll push that workaround into our Fedora dist-git and build for F26 and F27, just for to be sure. I am currently working on that migration.

Comment 13 Zdenek Dohnal 2017-06-19 18:10:03 UTC
Built as https://koji.fedoraproject.org/koji/taskinfo?taskID=20067466 . I'll close this bug after I finish migration libgnome-keyring -> libsecret.

Comment 14 Zdenek Dohnal 2017-06-28 14:08:02 UTC
Seth,

would you mind testing this scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=20227545 ? This is the build without previous workaround and libgnome-keyring usage is gone and substituted by libsecret.

Comment 15 Seth Jennings 2017-06-28 14:20:10 UTC
system-config-printer-1.5.9-5.fc26.x86_64 works great for me.  Thanks!


Note You need to log in before you can comment on or make changes to this bug.