Bug 1401286 - OVN provider driver RPM does not clean all changes on removal
Summary: OVN provider driver RPM does not clean all changes on removal
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-provider-ovn
Classification: oVirt
Component: driver
Version: unspecified
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ovirt-4.1.0-beta
: ---
Assignee: Marcin Mirecki
QA Contact: Mor
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-04 11:23 UTC by Mor
Modified: 2017-02-15 14:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-15 14:58:47 UTC
oVirt Team: Network
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 68473 0 master MERGED Include .pyc and .pyo files in the drivder rpm 2016-12-15 07:39:47 UTC
oVirt gerrit 69006 0 master MERGED Remove direcories during rpm remove 2016-12-23 09:05:33 UTC

Description Mor 2016-12-04 11:23:56 UTC
Description of problem:
OVN provider driver removal action does not remove all changes done by the installation and OVN configuration actions.

1. Python compiled file exists in:
/usr/lib/python2.7/site-packages/vdsm/tool/ovn_config.pyc
This is also relevant to (but not yet tested):
/usr/libexec/vdsm/hooks/before_device_create/ovirt_provider_ovn_hook.pyc
/usr/libexec/vdsm/hooks/before_nic_hotplug/ovirt_provider_ovn_hook.pyc

2. OVN bridge interface is not removed (created by setup_ovn_controller.sh):
ovs-vsctl show output:
    Bridge br-int
        fail_mode: secure
        Port br-int
            Interface br-int
                type: internal
        Port "ovn-9abf38-0"
            Interface "ovn-9abf38-0"
                type: geneve
                options: {csum="true", key=flow, remote_ip="10.35.128.5"}
    ovs_version: "2.6.90"

Version-Release number of selected component (if applicable):
ovirt-provider-ovn-driver: 1.0-1.fc24

How reproducible:
100%

Steps to Reproduce:
1. Install ovirt-provider-ovn-driver RPM on OVN node.
2. Use vdsm-tool ovn-config {provider_ip} {host_ip} to configure OVN tunnel.
3. Remove ovirt-provider-ovn-driver RPM from OVN node.

Actual results:
There are leftovers.

Expected results:
1. .pyc files should be removed from the installation directories.
2. Bridge interface should be removed.

Additional info:

Comment 1 Dan Kenigsberg 2016-12-04 13:00:26 UTC
br-int is created by ovn-controller, and I am not sure if it should remove it automatically (as it could provide connectivity to something).

pyc files must be collected.

Comment 2 Marcin Mirecki 2016-12-14 14:57:08 UTC
pyc files will be cleaned

br-int is the ovn integration bridge. It can be used for more than just the ovirt networking. It should only be removed by the ovn admin.

Comment 3 Mor 2016-12-19 11:59:44 UTC
I tried to verify it on today's build. Directory: /usr/libexec/vdsm/hooks/ovirt-provider-ovn exists on removal.

Comment 4 Mor 2016-12-28 07:59:59 UTC
I verified it on version: ovirt-provider-ovn-driver-1.0-1.20161228093622.git3b3d6e1.fc24.noarch


Note You need to log in before you can comment on or make changes to this bug.