Bug 1402368 - wrong c++ header file supplied
Summary: wrong c++ header file supplied
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: rb_libtorrent
Version: 25
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Alessandro Locati
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-07 11:52 UTC by dzmat
Modified: 2016-12-11 10:39 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-11 10:39:02 UTC
Type: Bug


Attachments (Terms of Use)

Description dzmat 2016-12-07 11:52:52 UTC
Description of problem: Actually problem is in rb_libtorrent-devel package. 

Version rb_libtorrent-devel-1.1.1-1.fc25.i686.rpm contains wrong header file 
"/usr/include/libtorrent/fingerprint.hpp" This header file contains much lesser string than upstream and miss function generate_fingerprint() and other declarations


Version-Release number of selected component (if applicable):
rb_libtorrent-devel-1.1.1-1.fc25.i686.rpm

How reproducible:
Just compare bundled file in rpm and upstream file https://github.com/arvidn/libtorrent/blob/RC_1_1/include/libtorrent/fingerprint.hpp

Actual results:
header differs from upstream

Expected results:
header should be the same as upstream

Additional info:
fedora24 version 1.0.8 contained normal header, as I have had compiled qbittorent against it without difficulties.

Comment 1 dzmat 2016-12-07 13:51:22 UTC
It looks like new function generate_fingerprint() appeared in rb_libtorrent upstream at 25 Oct 2016 and was used by qbittorrent master branch at 31 Oct 2016. 

So - the only thing I need is just refreshed version of rb_libtorrent*.

Dear maintainers, could you please, issue new version? My qbittorrent tinkering process is disrupted by this inconsistency.

Thank you in advance.

Comment 2 Fabio Alessandro Locati 2016-12-07 14:08:16 UTC
I think upstream screwed up. They changed files in a release that was already released.
You should probably ask them to release a new version (aka: new number) with all the proper files. At that point we can package it.

Cheers,
Fale


Note You need to log in before you can comment on or make changes to this bug.