Bug 1403329 - glibc: new condvar lacks support for GDB pretty-printers
Summary: glibc: new condvar lacks support for GDB pretty-printers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: glibc
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Torvald Riegel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-09 16:45 UTC by Florian Weimer
Modified: 2018-05-03 08:24 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-03 08:24:37 UTC
Type: Bug


Attachments (Terms of Use)

Description Florian Weimer 2016-12-09 16:45:36 UTC
The new condvar implementation is not supported by the GDB pretty-printers.

I will have to disable them (at least for condvars) because this blocks updating Fedora rawhide.

Comment 1 Florian Weimer 2016-12-09 16:46:11 UTC
To be clear, this is an issue which manifests at build time, so it is a hard blocker for glibc development.

Comment 2 Carlos O'Donell 2016-12-09 16:51:38 UTC
Torvald,

Could you please have a look at this?

commit 23b5cae1af04f2d912910fdaf73cb482265798c1
Author: Martin Galvan <martin.galvan>
Date:   Thu Dec 8 18:59:02 2016 +0530

    Add pretty printers for the NPTL lock types

We now have pretty printers for the NPTL lock types, and we need subsequent changes to them to match the new condvar implemenation.

Effectively it's a new requirement on any implementation changes.

There are now also tests for these e.g. nptl/test-*-printers* which use gdb and python (expect framework) to drive gdb and a coupled test.

Comment 3 Torvald Riegel 2016-12-09 17:03:57 UTC
So I suppose we need new patches for condvar and rwlock, which we'll then use instead of the old ones for Rawhide.  I'll put it on my list.

Comment 4 Florian Weimer 2016-12-09 17:29:02 UTC
I have a workaround with which I can build glibc in rawhide.  I'll use that for the time being.  It means that we currently do not have the pretty-printers installed.

Comment 5 Carlos O'Donell 2017-01-10 20:17:00 UTC
This is fixed upstream:

commit ed19993b5b0d05d62cc883571519a67dae481a14
Author: Torvald Riegel <triegel>
Date:   Wed May 25 23:43:36 2016 +0200

    New condvar implementation that provides stronger ordering guarantees.

Which has pretty printer support rolled in.

Comment 6 Fedora End Of Life 2017-02-28 10:45:33 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 7 Fedora End Of Life 2018-05-03 07:59:40 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 8 Florian Weimer 2018-05-03 08:24:37 UTC
The commit in comment 5 went into glibc 2.25, so this is actually fixed in Fedora 26.


Note You need to log in before you can comment on or make changes to this bug.