Bug 1403634 - "oadm manage-node drain" is suggested in "oadm manage-node --evacuate" but it does not work and not in help info
Summary: "oadm manage-node drain" is suggested in "oadm manage-node --evacuate" but it...
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 3.4.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Maciej Szulik
QA Contact: Xingxing Xia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-12 01:42 UTC by XiaochuanWang
Modified: 2019-06-27 06:13 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-27 06:13:48 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description XiaochuanWang 2016-12-12 01:42:06 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 XiaochuanWang 2016-12-12 02:29:58 UTC
Description of problem:
`oadm manage-node --evacuate` will show "Flag --evacuate has been deprecated, use 'oadm manage-node drain NODE' instead", but `oadm manage-node drain` doesn't work and it's not in oadm manage-node -h

Version-Release number of selected component (if applicable):
oc/oadm v3.4.0.34+87d9d8d

How reproducible:
Always

Steps to Reproduce:
1. # oadm manage-node <node> --evacuate --dry-run
Flag --evacuate has been deprecated, use 'oadm manage-node drain NODE' instead

Listing matched pods on node: <node>

NAME                            READY     STATUS      RESTARTS   AGE
...

2. # oadm manage-node drain <node> --dry-run
error: must provide a node operation. Supported operations: --schedulable, --evacuate and --list-pods
See 'oadm manage-node -h' for help and examples.

3. # oadm manage-node -h

Actual results:
1. Succeed to run, but it indicate user to use "drain"
2. Failed to run with "drain"
3. There is no "drain"

Expected results:
Since "drain" does not work and it's not in help info, should drop the message for "drain".
If need to use "drain", then it's a functional error.

Additional info:

Comment 2 Michal Fojtik 2016-12-12 15:11:58 UTC
The proper syntax is `oadm drain` not `oadm manage-node drain`.

Comment 3 Michal Fojtik 2016-12-12 15:19:46 UTC
PR: https://github.com/openshift/origin/pull/12226

Comment 4 Tracy Rankin 2016-12-12 22:13:12 UTC
Per convo with mfojtik, this is not a blocker.  Removing from 3.4.


Note You need to log in before you can comment on or make changes to this bug.