Bug 1404237 - Default organization name is possible to change by webui
Summary: Default organization name is possible to change by webui
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite 5
Classification: Red Hat
Component: WebUI
Version: 580
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jiří Dostál
QA Contact: Radovan Drazny
URL:
Whiteboard:
Depends On:
Blocks: 1340444
TreeView+ depends on / blocked
 
Reported: 2016-12-13 13:01 UTC by Pavel Studeník
Modified: 2017-06-21 12:08 UTC (History)
5 users (show)

Fixed In Version: spacewalk-java-2.5.14-62-sat
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-21 12:08:31 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Pavel Studeník 2016-12-13 13:01:56 UTC
Description of problem:
It possible to change default organization name (from page create first user)  in /rhn/admin/multiorg/OrgDetails.do?oid=1

Version-Release number of selected component (if applicable):
spacewalk-java-2.5.14-32.el6sat.noarch

How reproducible:
always on Satellite 5.8

Steps to Reproduce:
1. go to page /rhn/admin/multiorg/OrgDetails.do?oid=1
2. change field "Organization Name"

Actual results:
It is possible to change it.

Expected results:
In previous version it is not possible and I suppose that it is regression.

Comment 1 Jiří Dostál 2016-12-15 15:54:55 UTC
According to a36ea1f736aff70877153b9c3f616f893cc25fc0, it's more feature then Bug. Maybe we can treat this BZ as RFE request with attached fix as I was not able to find corresponding BZ.

Comment 2 Grant Gainey 2016-12-15 16:16:54 UTC
I don't think this is an RFE - unless someone can show that this breaks something, being able to change the human-readable org-name in Satellite is a feature that our customers like.

Comment 3 Pavel Studeník 2016-12-15 20:38:54 UTC
I guess the first organization is created during activation by name from certification (or manifest) in Satellite. In Spacewalk situation is different and first organization is created on first page by webui - and it is ok that you can change it by webui again, but it is spacewalk. Not Satellite. In my opinion it is bug, not feature. 

correct behaviour: the first organization is NOT possible to change by webui.

Comment 4 Grant Gainey 2016-12-15 21:00:38 UTC
(In reply to Pavel Studeník from comment #3)
> I guess the first organization is created during activation by name from
> certification (or manifest) in Satellite. In Spacewalk situation is
> different and first organization is created on first page by webui - and it
> is ok that you can change it by webui again, but it is spacewalk. Not
> Satellite. In my opinion it is bug, not feature. 
> 
> correct behaviour: the first organization is NOT possible to change by webui.

Ah, those are very good points - I forgot that first-org matches the orgname in the satcert, for Satellite. Allowing it to change will just cause confusion in GSS/Customer Service.

Jiri, this is (in my opinion anyway) worth reverting for Sat5.8

Comment 8 Radovan Drazny 2017-03-01 12:32:41 UTC
Well, WebUI has been changed and it's not possible to change name of default org. Name for orgs with OID=2 and higher can be changed successfully. So far so good.

Problem is, there is still an active button "Update organization" on default org Details page. When pressed, there is an error messasge "Organization Name must be between 3 and 128 characters", which in the given context makes no sense.
I guess it would be better to disable the button, as with the ability to change the name of the default org removed, there is actually nothing to "update" on default org Details page.

Comment 10 Radovan Drazny 2017-05-16 12:14:19 UTC
Verified on Satellite-5.8-RHEL-6-20170515.n.0. The "Update organization" button is disabled for default org (OID=1). It is still possible to rename other orgs (OID = 2 and higher).

VERIFIED

Comment 11 Ales Dujicek 2017-06-09 11:23:17 UTC
reverified

spacewalk-java-2.5.14-89.el6sat.noarch

webui does not allow me to change org1 name


Note You need to log in before you can comment on or make changes to this bug.