Hide Forgot
Description of problem: update on host_broker fails with reason conflict also if nothing has to be updated. This small python script could reproduce the issue: import ovirtsdk.api fqdn='enginevm.localdomain' username='admin@internal' password='mypassword' engine_api = ovirtsdk.api.API( url='https://{fqdn}/ovirt-engine/api'.format( fqdn=fqdn, ), username=username, password=password, insecure=True, ) h = engine_api.hosts.list()[0] host_broker = engine_api.hosts.get(id=h.get_id()) host_broker.update() Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. run the provided script on an host not in maintenance mode 2. 3. Actual results: [root@c72he20161213h1 ~]# python test.py Traceback (most recent call last): File "test.py", line 18, in <module> host_broker.update() File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/brokers.py", line 14157, in update headers={"Correlation-Id":correlation_id, "Expect":expect} File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/proxy.py", line 68, in update return self.request('PUT', url, body, headers, cls=cls) File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/proxy.py", line 122, in request persistent_auth=self.__persistent_auth File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/connectionspool.py", line 79, in do_request persistent_auth) File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/connectionspool.py", line 162, in __do_request raise errors.RequestError(response_code, response_reason, response_body) ovirtsdk.infrastructure.errors.RequestError: status: 409 reason: Conflict detail: Cannot edit Host. Host parameters cannot be modified while Host is operational. Please switch Host to Maintenance mode first. Expected results: If nothing has to be updated, it shouldn't fail Additional info: In 3.6 and 4.0 the same code wasn't failing.
This is currently blocking ovirt-hosted-engine-setup since it uses host_broker.upgrade to poll till the host gets into the right status.
(In reply to Simone Tiraboschi from comment #1) > This is currently blocking ovirt-hosted-engine-setup since it uses > host_broker.upgrade to poll till the host gets into the right status It doesn't make sense to use update and poll (HTTP PUT). Why not to just get the object (HTTP GET)?
(In reply to Oved Ourfali from comment #2) > (In reply to Simone Tiraboschi from comment #1) > > This is currently blocking ovirt-hosted-engine-setup since it uses > > host_broker.upgrade to poll till the host gets into the right status > > It doesn't make sense to use update and poll (HTTP PUT). > Why not to just get the object (HTTP GET)? We just need a patch on ovirt-hosted-engine-setup. Not that complex.
(In reply to Oved Ourfali from comment #2) > (In reply to Simone Tiraboschi from comment #1) > > This is currently blocking ovirt-hosted-engine-setup since it uses > > host_broker.upgrade to poll till the host gets into the right status > > It doesn't make sense to use update and poll (HTTP PUT). > Why not to just get the object (HTTP GET)? can you please paste here the code to fix to the reproducer code in the bug description?
(In reply to Sandro Bonazzola from comment #4) > (In reply to Oved Ourfali from comment #2) > > (In reply to Simone Tiraboschi from comment #1) > > > This is currently blocking ovirt-hosted-engine-setup since it uses > > > host_broker.upgrade to poll till the host gets into the right status > > > > It doesn't make sense to use update and poll (HTTP PUT). > > Why not to just get the object (HTTP GET)? > > can you please paste here the code to fix to the reproducer code in the bug > description? Seems like Simone knows what to do. If needed he can contact me offline.
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
There has been issue about inability to update some host attributes while host is not in maintenance, but AFAIK all of them should be fixed in 4.1.1. So is this still a regression or even a blocker? I know the fix make sense and should be present anyway, but is this still an issue on 4.1.1 even without the fix? If not then we may remove regression/blocker from the bug, right?
We modified ovirt-hosted-engine-setup code to use GET instead of POST for that requests so for sure it's not a blocker anymore although it's still worth to get it fixed.
OK, removing Regression and blocker? and also moving to Integration, as the fix is provided within HE setup code. If there's something more needed from infra feel free to move back
Verified on ovirt-hosted-engine-setup-2.2.0-0.0.master.20170913082146.git120d800.el7.centos.noarch [root@master-vds10 ovirt-hosted-engine-ha]# python test_bug.py [root@master-vds10 ovirt-hosted-engine-ha]# Script pass without any Tracebacks
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.