Bug 1408498 - [PATCH] OpenSceneGraph.spec: missing BuildRequires for Collada and EXR support
Summary: [PATCH] OpenSceneGraph.spec: missing BuildRequires for Collada and EXR support
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: OpenSceneGraph
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-23 20:50 UTC by François Cami
Modified: 2017-01-09 00:58 UTC (History)
1 user (show)

Fixed In Version: OpenSceneGraph-3.4.0-6.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-09 00:58:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch for OpenSceneGraph.spec (1.75 KB, patch)
2016-12-23 20:50 UTC, François Cami
no flags Details | Diff

Description François Cami 2016-12-23 20:50:47 UTC
Created attachment 1235106 [details]
patch for OpenSceneGraph.spec

Description of problem:

The DAE and EXR plugins are missing from Fedora's OpenSceneGraph.

Please add:

BuildRequires: OCE-devel
BuildRequires: collada-dom-devel
BuildRequires: libvncserver-devel
BuildRequires: libcurl-devel
BuildRequires: OpenEXR-devel

And obviously:
%{_libdir}/osgPlugins-%{apivers}/osgdb_exr.so
%{_libdir}/osgPlugins-%{apivers}/osgdb_dae.so

to OpenSceneGraph.spec

Version-Release number of selected component (if applicable):
OpenSceneGraph-3.4.0-4.fc24.x86_64

A patch against 3.4.0-6 is attached.
Could you please update F25 + Rawhide?

Comment 1 François Cami 2016-12-23 20:51:46 UTC
I also had to add:
 -DCOLLADA_INCLUDE_DIR=$(pkg-config collada-dom-141 --variable=includedir)
to %cmake.

Comment 2 Ralf Corsepius 2016-12-29 11:50:59 UTC
Thanks for the proposal. I am looking into it and am working on gradually merging it into the spec.

2 questions, however:
- Is there any particular reason for using "collada-dom-141"?
AFAICT, OSG builds fine against "collada-dom" (==collada-dom2.4), but I don't know if this actually works at runtime or not.

- Why are you adding BR: OCE-devel?
May-be, I am missing something, I can't spot anything in OSG's sources, where OCE is being used.

Comment 3 Fedora Update System 2016-12-31 12:57:03 UTC
OpenSceneGraph-3.4.0-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dbc4444111

Comment 4 François Cami 2016-12-31 17:46:38 UTC
* Re Collada version, 1.4.1 was mentioned in the plugin's README:

https://github.com/openscenegraph/OpenSceneGraph/blob/master/src/osgPlugins/dae/README.txt

I have to admit I didn't check what happened without specifying the version.


* Re OCE-devel: this is for OpenCASCADE. I remember while building OSG that it searched for this ( CMakeModules/FindOpenCascade.cmake ). However,  a plugin called osgdb_opencascade should be built and it's clearly not the case. I'll investigate further.


Thanks for merging stuff :)

Comment 5 Fedora Update System 2017-01-01 00:24:51 UTC
OpenSceneGraph-3.4.0-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dbc4444111

Comment 6 Fedora Update System 2017-01-09 00:58:19 UTC
OpenSceneGraph-3.4.0-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.