Spec URL: https://www.happyassassin.net/reviews/python-pytest-httpbin/python-pytest-httpbin.spec SRPM URL: https://www.happyassassin.net/reviews/python-pytest-httpbin/python-pytest-httpbin-0.2.3-1.fc26.src.rpm Description: Pytest-httpbin creates a pytest fixture that is dependency-injected into your tests. It automatically starts up a HTTP server in a separate thread running a local instance of httpbin (a web service for testing HTTP libraries) and provides your test with the URL in the fixture. Fedora Account System Username: adamwill
Taking this review.
One very obvious problem, you're using %{srcname} when it has never been defined in the spec. fedora-review blew up in a very odd way because of it. Please fix. :)
Spec URL: https://www.happyassassin.net/reviews/python-pytest-httpbin/python-pytest-httpbin.spec SRPM URL: https://www.happyassassin.net/reviews/python-pytest-httpbin/python-pytest-httpbin-0.2.3-2.fc26.src.rpm (fixes subpackage names, d'oh)
Well, it looks like there's just one major issue: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages/pytest_httpbin-0.2.3-py3.6.egg-info, /usr/lib/python2.7/site- packages/pytest_httpbin, /usr/lib/python3.6/site- packages/pytest_httpbin, /usr/lib/python2.7/site- packages/pytest_httpbin-0.2.3-py2.7.egg-info, /usr/lib/python3.6/site- packages, /usr/lib/python3.6 Also, why are these here? python2-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cacert.pem python2-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cert.pem python3-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cacert.pem python3-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cert.pem
(In reply to Neal Gompa from comment #4) > Also, why are these here? > > python2-pytest-httpbin.noarch: W: pem-certificate > /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cacert.pem > python2-pytest-httpbin.noarch: W: pem-certificate > /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cert.pem > python3-pytest-httpbin.noarch: W: pem-certificate > /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cacert.pem > python3-pytest-httpbin.noarch: W: pem-certificate > /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cert.pem And of course, if I read the spec more carefully, I would know the answer to this! D'oh. Anyway, this is okay with me.
"Well, it looks like there's just one major issue:" fixed in -3: Spec URL: https://www.happyassassin.net/reviews/python-pytest-httpbin/python-pytest-httpbin.spec SRPM URL: https://www.happyassassin.net/reviews/python-pytest-httpbin/python-pytest-httpbin-0.2.3-3.fc26.src.rpm "Also, why are these here?" The point of httpbin is to test HTTP transactions. pytest-httpbin provides a test fixture which is an httpbin-based HTTP server. In order to test HTTPS transactions using that server, it needs a server cert, which is what cert.pem is, and it needs to provide a trust bundle which says the server cert is trusted, which is what cacert.pem is. They won't be used by anything besides pytest-httpbin itself (and the cert is only valid for 127.0.0.1 in any case).
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /home/makerpm/1409192-python-pytest- httpbin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.6/site-packages, /usr/lib/python3.6 [-]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages, /usr/lib/python3.6 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -pytest-httpbin , python3-pytest-httpbin [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-pytest-httpbin-0.2.3-3.fc26.noarch.rpm python3-pytest-httpbin-0.2.3-3.fc26.noarch.rpm python-pytest-httpbin-0.2.3-3.fc26.src.rpm python2-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cacert.pem python2-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cert.pem python3-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cacert.pem python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/certs.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/version.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/plugin.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/__init__.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/serve.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/certs.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/__init__.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cert.pem python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/serve.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/plugin.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/version.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) 3 packages and 0 specfiles checked; 10 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- python2-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cacert.pem python2-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pytest_httpbin/certs/cert.pem python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/__init__.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/__init__.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/certs.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/certs.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/plugin.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/plugin.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/serve.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/serve.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/version.cpython-36.opt-1.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/pytest_httpbin/__pycache__/version.cpython-36.pyc expected 3361 (3.6), found 3379 (unknown) python3-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cacert.pem python3-pytest-httpbin.noarch: W: pem-certificate /usr/lib/python3.6/site-packages/pytest_httpbin/certs/cert.pem 2 packages and 0 specfiles checked; 10 errors, 4 warnings. Requires -------- python2-pytest-httpbin (rpmlib, GLIBC filtered): python(abi) python-decorator python-flask python-httpbin python-pytest python-six python3-pytest-httpbin (rpmlib, GLIBC filtered): python(abi) python3-decorator python3-flask python3-httpbin python3-pytest python3-six Provides -------- python2-pytest-httpbin: python-pytest-httpbin python2-pytest-httpbin python2.7dist(pytest-httpbin) python2dist(pytest-httpbin) python3-pytest-httpbin: python3-pytest-httpbin python3.6dist(pytest-httpbin) python3dist(pytest-httpbin) Source checksums ---------------- https://github.com/kevin1024/pytest-httpbin/archive/e4ffbae0a44895ae8ddfdffdebd1b5e062d1d743/pytest-httpbin-0.2.3.tar.gz : CHECKSUM(SHA256) this package : 07ac0fad500310d6bc2494fe286a66de68d8551f4654dad62776cea0facdba7d CHECKSUM(SHA256) upstream package : 07ac0fad500310d6bc2494fe286a66de68d8551f4654dad62776cea0facdba7d Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -b 1409192 -m ../../home/makerpm/fedora-rawhide-x86_64-koji Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
So, I already know about the issue with rpmlint and Python 3.6, and that's being addressed in this PR: https://github.com/rpm-software-management/rpmlint/pull/86 So those errors can be ignored. I know about the PEM certs, and that's okay. I'm fairly certain that there's a bug in the actual python3 package causing rpmlint to say there's no known owner for usr/lib/python3.6/site-packages and /usr/lib/python3.6, as those should definitely not be owned by this package. Keeping that in mind, this looks good to me. PACKAGE APPROVED.
For the record, /usr/lib/python3.6/site-packages and /usr/lib/python3.6 are owned by system-python-libs , which is required by python3. Thanks for the review!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-httpbin