Bug 1409382 - Review Request: python36 - Version 3.6 of the Python programming language
Summary: Review Request: python36 - Version 3.6 of the Python programming language
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iryna Shcherbina
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-01 13:27 UTC by Miro Hrončok
Modified: 2017-04-18 20:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-18 20:35:11 UTC
Type: ---
Embargoed:
ishcherb: fedora-review+


Attachments (Terms of Use)

Description Miro Hrončok 2017-01-01 13:27:21 UTC
Spec URL: https://github.com/fedora-python/python36/raw/master/python36.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python36-3.6.0-1.fc25.src.rpm

Description: Python 3.6 package for developers.
This package exists to allow developers to test their code against an newer
version of Python. This is not a full Python stack and if you wish to run
your applications with Python %{pybasever}, update your Fedora to a newer
version.

Fedora Account System Username: churchyard
Koji scratch F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=17135413
Koji scratch F24: https://koji.fedoraproject.org/koji/taskinfo?taskID=17135428

This package is currently intended for Fedora 24 and 25 only.

In the review, please note that this is a backport of the python3 package and the spec might be more complicated than necessary for the sake of much easier portability between python36 and python3.

On the other hand, please be thorough about things like conflicts with python3 package, upgrade paths, etc.

Also please note that:

https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Process

Contributors and reviewers MUST follow the Package Review Process, with the following exceptions:

* The package is being created so that multiple versions of the same package can coexist in the distribution. The package MUST be properly named according to the naming guidelines and MUST NOT conflict with all other versions of the same package.

I'd like the reviewer to check this condition first.

Comment 1 Iryna Shcherbina 2017-01-17 07:56:36 UTC
-----
NOTES
-----
Upgrade path is clean from F24 to F25.

Rewheel mode is removed. [0]
Debug build is disabled. [1]

[0] https://github.com/fedora-python/python36/commit/b5cda81775024ea2c7c74515f3593d7a5022a8fc
[1] https://github.com/fedora-python/python36/commit/51bf9a17b445c120fbcc603246205ea225533f69

Package is flat, meaning that there are no subpackages, all the files and directories are at the main package.

Binaries, libraries and man pages, which conflict with the system python3 package, are removed or renamed. The binary for this package is renamed to python36.

python(abi) is not required/provided.

python3-setuptools and python3-pip come bundled with this package, so to comply with the packaging guidelines, virtual provides are added:

$ rpm -q --provides python36
bundled(python3-pip) = 9.0.1
bundled(python3-setuptools) = 28.8.0
...

Libraries are installed into %{_libdir}/python3.6, so there is no conflict with %{_libdir}/python3.5 at F24 and F25.


Tested on F24 virtual machine, which I upgraded to F25. No issues observed and nothing conflicts with base python package.
Invoking 'python3' command fires up the python 3.5.1 (F24) or 3.5.2 (F25) shell, and 'python36' - 3.6.0 shell.
Doing some more testing before approving the package.

-------
RPMLINT
-------
$ rpmlint python36-3.6.0-1.fc25.src.rpm 
python36.src:205: W: macro-in-comment %{_lib}
python36.src:388: W: macro-in-comment %{pybasever}
python36.src:622: E: hardcoded-library-path in %{_prefix}/lib/debug/%{_libdir}
python36.src:668: E: hardcoded-library-path in %{_prefix}/lib/python%{pybasever}/site-packages/__pycache__
python36.src:705: W: macro-in-comment %{_pyconfig32_h}
python36.src:707: W: macro-in-comment %{_pyconfig64_h}
python36.src:769: W: macro-in-comment %{pylibdir}
python36.src:829: E: use-of-RPM_SOURCE_DIR
python36.src:952: E: hardcoded-library-path in %{_prefix}/lib/python%{pybasever}
python36.src:953: E: hardcoded-library-path in %{_prefix}/lib/python%{pybasever}/site-packages
python36.src:954: E: hardcoded-library-path in %{_prefix}/lib/python%{pybasever}/site-packages/__pycache__/
python36.src:40: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 40)
python36.src: W: patch-not-applied Patch146: 00146-hashlib-fips.patch
1 packages and 0 specfiles checked; 6 errors, 7 warnings.

Comment 2 Iryna Shcherbina 2017-01-18 10:13:19 UTC
Tested on F24 virtual machine, which I upgraded to F25 and then to rawhide. 
python35 and python36 can work side by side without clashing in F24 and F25.

After upgrade to rawhide, python36 package gets obsoleted by python3 package, invoking python3 fires up 3.6.0 shell.
Upgrade paths are clean (F24->F25, F25->rawhide).

The rpmlint warnings are not blocking, but please consider fixing them.

Package approved.

Comment 3 Miro Hrončok 2017-01-18 10:58:10 UTC
Thank You, Iryna.

Comment 4 Gwyn Ciesla 2017-01-18 13:51:46 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python36

Comment 5 Fedora Update System 2017-01-21 02:42:52 UTC
python36-3.6.0-7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9a49185148

Comment 6 Fedora Update System 2017-01-21 02:43:38 UTC
python36-3.6.0-7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-51764da5a4

Comment 7 Fedora Update System 2017-01-21 21:53:01 UTC
python36-3.6.0-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-51764da5a4

Comment 8 Fedora Update System 2017-01-21 22:26:02 UTC
python36-3.6.0-7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9a49185148


Note You need to log in before you can comment on or make changes to this bug.