Bug 141588 - local variable used before set
Summary: local variable used before set
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: gaim
Version: 3
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Reed
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-12-02 10:31 UTC by David Binderman
Modified: 2007-11-30 22:10 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-12-03 01:28:11 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Binderman 2004-12-02 10:31:06 UTC
Description of problem:

I just tried to compile package gaim-1.0.1-3 from 
Redhat Fedora Core 3.

The compiler said

zephyr.c(1081): remark #592: variable "from" is used before its value
is set

The source code is

	handle_message(gc,notice,from);

I agree with the compiler. This code would benefit from rework.

Suggest that from is not used in routine handle_message, so can
be safely deleted.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Mark Doliner 2004-12-02 23:04:09 UTC
The variable "from" isn't actually _used_ anywhere.  It's just passed
to a function, and that function completely ignores it.  Why the
parameter is there in the first place... your guess is as good as
mine.  I've removed it in CVS head and in oldstatus.  This error
should be gone in Gaim 1.1.0.


Note You need to log in before you can comment on or make changes to this bug.