Latest upstream release: v1.18.0 Current version/release in rawhide: 1.17.0-6.fc24 URL: http://github.com/ejmr/php-mode Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream. Based on the information from anitya: https://release-monitoring.org/project/8348/
Patching or scratch build for emacs-php-mode-1.17.0 failed.
Created attachment 1245292 [details] Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.
Patches were not touched. All were applied properly
Latest upstream release: v1.18.1 Current version/release in rawhide: 1.17.0-6.fc24 URL: http://github.com/ejmr/php-mode Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream. Based on the information from anitya: https://release-monitoring.org/project/8348/
Created attachment 1246636 [details] Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.
Latest upstream release: v1.18.2 Current version/release in rawhide: 1.17.0-6.fc24 URL: http://github.com/ejmr/php-mode Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream. Based on the information from anitya: https://release-monitoring.org/project/8348/
Created attachment 1247307 [details] Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.
I have filed https://github.com/ejmr/php-mode/issues/336 (pull request https://github.com/ejmr/php-mode/pull/338) and https://github.com/ejmr/php-mode/issues/337 for two compilation warnings and https://github.com/ejmr/php-mode/issues/339 for a compilation error: | + /usr/bin/emacs -batch --no-init-file --no-site-file --eval '(progn (setq load-path (cons "." load-path)))' -f batch-byte-compile skeleton/php-array.el skeleton/php-classobj.el skeleton/php-control-structures.el skeleton/php-crack.el skeleton/php-current.el skeleton/php-dio.el skeleton/php-dom.el skeleton/php-exceptions.el skeleton/php-exif.el skeleton/php-ext.el skeleton/php-filesystem.el skeleton/php-gd.el skeleton/php-math.el skeleton/php-pcre.el skeleton/php-regex.el skeleton/php-simplexml.el skeleton/php-strings.el skeleton/php-var.el skeleton/php-xmlparser.el skeleton/php-xmlreader.el | Eval error in the `c-lang-defconst' for `c-mode-menu' in php-mode: | In toplevel form: | skeleton/php-current.el:33:1:Error: Invalid function: (append (quote (["Complete function name" php-complete-function t] ["Browse manual" php-browse-manual t] ["Search documentation" php-search-documentation t] ["----" t])) (c-get-lang-constant (quote c-mode-menu) (quote (cc-langs))))
I was mistaken about attributing the error to php-mode; in fact %_emacs_bytecompile does not work with files in subdirectories (cf. bug #1420129).
Created attachment 1324710 [details] Patch for 1.18.2-1. I have updated the spec file for 1.18.2 and fixed a couple of bits and bobs. It seems to be working for me on Fedora 25 (cf. https://koji.fedoraproject.org/koji/taskinfo?taskID=21809506), but before I try to test the other releases & Co., I thought it might be easier to share the package so that more people can chime in. I think all changes should be explained in the patch or self-explanatory, if not, please advise. Similarly, any deviation from packaging guidelines is unintended, so if there is something "unusual", please point that out.
Petr, did you get a chance to look at my patch in comment #14? Would you prefer someone else to review it? Who would you suggest? Anything else I can do to move this forward?
Petr: *ping*. Thanks!
In rawhide fixed by commit https://src.fedoraproject.org/rpms/emacs-php-mode/c/fd406af41e122c28714507a9e3abef80aa21c6c5?branch=master The rest branches will follow soon.