Bug 142098 - missing expression in return statement
Summary: missing expression in return statement
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libgnomedb
Version: 3
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-12-07 10:38 UTC by David Binderman
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version: libgnomedb-1.0.4-4.i386.rpm
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-12-10 08:30:07 UTC


Attachments (Terms of Use)

Description David Binderman 2004-12-07 10:38:28 UTC
Description of problem:

I just tried to compile package libgnomedb-1.0.4-3 from 
Redhat Fedora Core 3.

The compiler said

gnome-db-grid.c(368): warning #117: non-void function
"popup_button_pressed_cb" should return a value

The source code is

        g_return_if_fail (GNOME_DB_IS_GRID (grid));

but

static gint
popup_button_pressed_cb (GtkWidget *widget, GdkEventButton *event,
gpointer user_data)
{

I agree with the compiler. This code would benefit from re-work to ensure
that this non-void function does return a value.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Caolan McNamara 2004-12-07 11:10:36 UTC
Accepted: I'll build a new rawhide package with the fix: Fix reported
and attached upstream to http://bugzilla.gnome.org/show_bug.cgi?id=160672

Comment 2 Caolan McNamara 2004-12-10 08:30:07 UTC
available as rawhide libgnomedb-1.0.4-4


Note You need to log in before you can comment on or make changes to this bug.