Bug 142099 - missing expression in return statement
Summary: missing expression in return statement
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: NetworkManager
Version: 3
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Williams
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-12-07 10:40 UTC by David Binderman
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-01-29 22:13:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Binderman 2004-12-07 10:40:03 UTC
Description of problem:

I just tried to compile package NetworkManager-0.3.1-3 from 
Redhat Fedora Core 3.

The compiler said

NMWirelessAppletDbus.c(853): warning #117: non-void function
"nmwa_dbus_update_active_device_strength" should return a value

The source code is

static gboolean nmwa_dbus_update_active_device_strength (gpointer
user_data)
{
        NMWirelessApplet *applet;

        g_return_if_fail (user_data != NULL);

I agree with the compiler. This code would benefit from re-work to ensure
that this non-void function does return a value.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Dan Williams 2005-01-29 22:13:10 UTC
Should be fixed.  Thanks.


Note You need to log in before you can comment on or make changes to this bug.