Bug 1421185 - Random attribute order in generated feeds
Summary: Random attribute order in generated feeds
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pelican
Version: 25
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Matthias Runge
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2017-02-10 14:57 UTC by Georg Sauthoff
Modified: 2017-12-12 10:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2017-12-12 10:25:45 UTC
Type: Bug

Attachments (Terms of Use)

Description Georg Sauthoff 2017-02-10 14:57:36 UTC
Description of problem:
The order of XML attributes in the generated feeds is random. This is a regression to upstream pelican because the Fedora pelican package changes the used feed generator.

Upstream pelican uses the feedgenerator python package - which is a fork of django.utils.feedgenerator. The pelican package patches this dependency which django's version (cf. python-pelican.spec):

# substitute feedgenerator with it's original django
sed -i 's|feedgenerator|django.utils.feedgenerator|' pelican/writers.py
sed -i "s|'feedgenerator >= 1.6', ||" setup.py
sed -i "s|'pytz >= 0a'|'pytz'|" setup.py

Pelican's feedgenerator implemented reproducible feed generation in 2013:

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. generate the feeds multiple times in a row

Actual results:
The generated bytes aren't byte identical because the order of XML attributes changes.

Expected results:
Reproducible feed generation, e.g. without other changes the generated feeds should be byte identical.

Additional info:
cf. this pull request for djanga.utils.feedgenerator that adds ordering:

main advantage of stable feed generation: better caching behavior

Comment 1 Matthias Runge 2017-08-14 07:02:27 UTC
I see, your pull request has been merged into Django. Congrats!

Comment 2 Fedora End Of Life 2017-11-16 19:12:07 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2017-12-12 10:25:45 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.