Bug 1430690 - leading spaces are trimmed from passwords if autologin is enabled
Summary: leading spaces are trimmed from passwords if autologin is enabled
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-keyring
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-09 10:20 UTC by Ondrej Holy
Modified: 2017-12-12 10:50 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-12 10:50:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 779808 0 None None None 2017-03-09 14:49:50 UTC

Description Ondrej Holy 2017-03-09 10:20:47 UTC
Description of problem:
Leading spaces are trimmed from passwords if autologin is enabled. It works correctly if autologin is disabled. I am not really sure why autologin triggers this, so maybe the bug is in a different component (it might be because of different PAM profiles if they are involved somehow in this at all)...

Version-Release number of selected component (if applicable):
Up to date Fedora 25. I created bug here and not in upstream, because it works on other distributions as per reporter on Czech Fedora forum [1].

How reproducible:
It is always reproducible using the following steps.

Steps to Reproduce:
1. Enable autologin for your user account (e.g. in Users panel) and reboot.
2. Set password with leading spaces, e.g. " test ":
$ secret-tool store --label=test test test

(I can reproduce it also over Seahorse and GVfs).

Actual results:
The returned password doesn't have the leading spaces.
$ secret-tool lookup test test
test 

Expected results:
The returned password should have the leading spaces.
$ secret-tool lookup test test
 test 

Additional info:
login.keyring contains the password including the leading spaces:
$ cat .local/share/keyrings/login.keyring | grep -A1 display-name=test
display-name=test
secret= test 

The examples are done over secret-tool, but this is not a bug in libsecret, because it affects also Seahorse, GVfs and probably all other keyring clients. I am just not able to get password over the keyring DBus API directly:
$ dbus-send --print-reply --dest=org.gnome.keyring /org/freedesktop/secrets/collection/login/76 org.freedesktop.Secret.Item.GetSecret objpath:/org/freedesktop/secrets/session/s1
Error org.freedesktop.Secret.Error.NoSession: The session does not exist

It was initially reported on Czech Fedora Forum:
[1] https://forum.mojefedora.cz/read.php?1,28267

Comment 1 Ray Strode [halfline] 2017-03-09 14:29:11 UTC
hey do you mind filing this upstream ?

Comment 2 Fedora End Of Life 2017-11-16 19:36:24 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2017-12-12 10:50:20 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.