Red Hat Bugzilla – Bug 145093
NULL used in place where non-NULL required
Last modified: 2007-11-30 17:10:58 EST
Description of problem:
I just tried to compile package vsftpd-2.0.1-8 from
Redhat Fedora development tree.
The compiler said
sysdeputil.c:640: warning: null argument where non-null required (arg 3)
The source code is
retval = sendfile(out_fd, in_fd, NULL, num_send);
Acording to the man page for sendfile, the third parameter must be a valid
pointer. Suggest code re-work.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Which gcc are you using? Did you changed any flags because my output seems to be
clear and I don't have any warnings on my system.
>Which gcc are you using?
Not sure, judging by the date, a recent gcc snapshot.
>Did you changed any flags because my output seems to be
>clear and I don't have any warnings on my system
I used flags -g -O2 -Wall.
The code stills seems to be wrong, even if you can't reproduce it.
Well, reading a man page, I can't say that this is wrong. The offset doesn't
change so I don't see any need to have a valid pointer there. Anyway it might be
better to report this to upstream with suggestion for rework while it doesn't
produce any bug.