Bug 1452202 - Put rpkg client back to /usr/bin
Summary: Put rpkg client back to /usr/bin
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: rpkg
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: cqi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-18 14:26 UTC by clime
Modified: 2017-07-27 21:13 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-27 21:12:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Put rpkg client back to /usr/bin (1.67 KB, patch)
2017-05-18 14:26 UTC, clime
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1460917 0 medium CLOSED Review Request: rpkg - Command-line client tool to DistGit 2021-02-22 00:41:40 UTC

Internal Links: 1460917

Description clime 2017-05-18 14:26:27 UTC
Created attachment 1280043 [details]
Put rpkg client back to /usr/bin

Description of problem:

Hey, I would like the rpkg client to be put back to /usr/bin directory again so that it is available as a general-purpose client to the dist-git package in Fedora/EPEL7. It is being mentioned as a recommended command line tool for it even in the upstream repo here https://github.com/release-engineering/dist-git.

The attached patch should do exactly that.

Comment 1 Dennis Gilmore 2017-05-18 20:22:46 UTC
upstream is at https://pagure.io/rpkg/ it was a very intentional decision to remove /usr/bin/rpkg. can you explain your use cases for it please?

Comment 2 clime 2017-05-20 15:09:59 UTC
Yes, upstream is at pagure.io but spec that decides where rpkg resides is in "downstream" here: https://src.fedoraproject.org/cgit/rpms/rpkg.git/tree/rpkg.spec.

Recently, a new dist-git package (v1.0) has been released (upstream is at https://github.com/release-engineering/dist-git) and for this package, the recommended command-line client is rpkg. That's basically why I need it back.

The dist-git package is free of anything distro-specific and can be used to maintain arbitrary collections of (s)rpm packages. As such, it needs a non-distro specific (in RHEL-based world) client, which is 'rpkg'. The dist-git package is in Fedora and EPEL7 and the client could be there as well.

Comment 3 cqi 2017-05-22 01:19:08 UTC
(In reply to clime from comment #2)
> Yes, upstream is at pagure.io but spec that decides where rpkg resides is in
> "downstream" here:
> https://src.fedoraproject.org/cgit/rpms/rpkg.git/tree/rpkg.spec.
> 
> Recently, a new dist-git package (v1.0) has been released (upstream is at
> https://github.com/release-engineering/dist-git) and for this package, the
> recommended command-line client is rpkg. That's basically why I need it back.

I'm curious from where you get the information of rpkg is the recommended command line client to interact with dist-git. I haven't see anywhere to tell that, at least in https://fedoraproject.org/wiki/Package_maintenance_guide, fedpkg should be the right one.

Comment 4 clime 2017-05-22 06:58:57 UTC
(In reply to cqi from comment #3)
> (In reply to clime from comment #2)
> > Yes, upstream is at pagure.io but spec that decides where rpkg resides is in
> > "downstream" here:
> > https://src.fedoraproject.org/cgit/rpms/rpkg.git/tree/rpkg.spec.
> > 
> > Recently, a new dist-git package (v1.0) has been released (upstream is at
> > https://github.com/release-engineering/dist-git) and for this package, the
> > recommended command-line client is rpkg. That's basically why I need it back.
> 
> I'm curious from where you get the information of rpkg is the recommended
> command line client to interact with dist-git. I haven't see anywhere to
> tell that, at least in
> https://fedoraproject.org/wiki/Package_maintenance_guide, fedpkg should be
> the right one.

Well, fedpkg is the client to use with Fedora DistGit which is richer if compared to the dist-git package (in addition to it, there is bodhi integration and pkgdb integration and also download path contains hashtype). It's just that rpkg as a tiny wrapper around pyrpkg is well suited to be a client of choice for the https://admin.fedoraproject.org/pkgdb/package/rpms/dist-git/ which is different from what Fedora uses in production at the moment.

Comment 5 Pavel Raiskup 2017-05-22 10:36:18 UTC
> I'm curious from where you get the information of rpkg is the recommended
> command line client to interact with dist-git.

Good point, I believe it is just matter of documenting it
properly in dist-git project documentation.

I agree that we need to have distro-agnostic tool -- and that's not
`fedpkg` definitely.  `rpkg` is neither distro agnostic (more like rhel
oriented) though that's the closest option.

Comment 6 clime 2017-05-31 06:28:16 UTC
What's the status here, please?

Comment 7 Dennis Gilmore 2017-06-06 20:20:43 UTC
(In reply to clime from comment #2)
> Yes, upstream is at pagure.io but spec that decides where rpkg resides is in
> "downstream" here:
> https://src.fedoraproject.org/cgit/rpms/rpkg.git/tree/rpkg.spec.

Not entirely sure what you mean here. the rpkg command afaik should be removed entirely.

> Recently, a new dist-git package (v1.0) has been released (upstream is at
> https://github.com/release-engineering/dist-git) and for this package, the
> recommended command-line client is rpkg. That's basically why I need it back.

/usr/bin/rpkg was only ever supposed ot be a reference implementation that existed because fedpkg, centpkg and other implementations imported and overloaded the functions in order to do their work. we are attempting to make rpkg be a library providing the core functionality and to improve the design or everything. 

> The dist-git package is free of anything distro-specific and can be used to
> maintain arbitrary collections of (s)rpm packages. As such, it needs a
> non-distro specific (in RHEL-based world) client, which is 'rpkg'. The
> dist-git package is in Fedora and EPEL7 and the client could be there as
> well.

each individuaal implementation is expected to come up with their own tooling based on rpkg in order to work with dist-git.  sounds like the upstream dist-git maintainers need to communicate with us a bit more and we can work to fix the documentation gap.

Comment 8 Pavel Raiskup 2017-06-07 05:09:14 UTC
> sounds like the upstream dist-git maintainers need to communicate with
> us a bit more and we can work to fix the documentation gap.

It rather sounds like nobody listens to the requests..  This is not about
documenting something in pyrpkg but about allowing end-users to just
deploy basic dist-git scenario without requiring them to create their own
packages (the removed 'rpkg' script was convenient enough).  Of course
if 'rpkg' is not enough, users can overload some internal methods of
pyrpkg (uhh!) to do their work ...

Comment 9 clime 2017-07-27 21:13:58 UTC
I think, this has been resolved by Bug 1460917 - Review Request: rpkg - Command-line client tool to DistGit.


Note You need to log in before you can comment on or make changes to this bug.