Bug 1452381 - Summit 2017 Satellite lab Feedback - User should be warned if space(s) is prefixed in Discovery Rules -> Search field
Summary: Summit 2017 Satellite lab Feedback - User should be warned if space(s) is pre...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Discovery Plugin
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: Unspecified
Assignee: Lukas Zapletal
QA Contact: Justin Sherrill
URL:
Whiteboard:
Depends On:
Blocks: 1459226
TreeView+ depends on / blocked
 
Reported: 2017-05-18 20:02 UTC by sthirugn@redhat.com
Modified: 2019-09-25 21:26 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-21 16:54:37 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description sthirugn@redhat.com 2017-05-18 20:02:22 UTC
Description of problem:
Summit 2017 Satellite lab Feedback - User should be warned if space(s) is prefixed in Discovery Rules -> Search field

Version-Release number of selected component (if applicable):
Satellite 6.2.9

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Satellite UI -> Configure -> Discovery Rules. Create a new Discovery rule.
2. Trigger a user error scenario in which a space is prefixed in the Discovery Rule -> Search field - something like ` name~mac*`
3. Provision a host via pxe and check if auto provisioning works

Actual results:
Auto provisioning does not work when search field had space prefixed (by mistake)

Expected results:
Warn the user if any input field is prefixed with space(s)

Additional info:
This may be applicable to all Settings field and not Discovery alone.

Comment 5 Rahul Bajaj 2017-07-20 11:14:46 UTC
I feel we should strip the spaces rather than displaying an error, what is your say lukas , sthirugn ?

Comment 6 Rahul Bajaj 2017-07-20 11:45:08 UTC
Ah! i see, one space is maditory. I guess then handling it on the client side would be appropriate.

Comment 7 Lukas Zapletal 2017-07-20 12:27:16 UTC
It's not mandatory, but users tend to press space in order to get dropdown helper, maybe stripping is better. We can also add model validator on top of that to make sure space won't sneak in via API.

Comment 11 Rahul Bajaj 2017-07-27 15:09:27 UTC
I am unable to re-produce this bug on upstream. As I am looking into the database, the search field is already stripped.

Comment 12 Lukas Zapletal 2017-08-07 15:48:41 UTC
Thanks please re-test.

Comment 13 Justin Sherrill 2017-08-09 19:25:33 UTC
Verified on snap-10, created a rule of "  name = foobar"   and it gets saved as "name = foobar"

Comment 14 Satellite Program 2018-02-21 16:54:37 UTC
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> > 
> > For information on the advisory, and where to find the updated files, follow the link below.
> > 
> > If the solution does not work for you, open a new bug report.
> > 
> > https://access.redhat.com/errata/RHSA-2018:0336


Note You need to log in before you can comment on or make changes to this bug.