Bug 145637 - suspicious code in assert statement
suspicious code in assert statement
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: howl (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alexander Larsson
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-20 06:17 EST by David Binderman
Modified: 2007-11-30 17:10 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-01-21 05:26:03 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description David Binderman 2005-01-20 06:17:23 EST
Description of problem:

I just had a look at the source code for package howl-0.9.8-2
from the Redhat Fedora development tree.

I found this

[root@localhost SPECS]# find ../BUILD/howl-0.9.8/ -name \*.c -print |
xargs grep "assert.*(.* = "
../BUILD/howl-0.9.8/src/lib/howl/MacOSX/macosx_socket.c:       
sw_assert(self->m_super.m_registered = SW_TRUE);
[root@localhost SPECS]#

IMHO, dubious code. Suggest remove assignment from the assert statement.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Alexander Larsson 2005-01-21 05:26:03 EST
This code isn't even built on fedora. report it upstream instead.

Note You need to log in before you can comment on or make changes to this bug.