Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1457492

Summary:	Issues with 4.1 Grub menu on iso builds
Product:	[oVirt] ovirt-node	Reporter:	Jimmy Martin <jimmy.r.martin>
Component:	Installation & Update	Assignee:	Yuval Turgeman <yturgema>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Qin Yuan <qiyuan>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	4.1	CC:	bugs, cshao, dguo, huzhao, jiawu, qiyuan, sbonazzo, stirabos, weiwang, yaniwang, ycui, yzhao
Target Milestone:	ovirt-4.1.3	Flags:	sbonazzo: ovirt-4.1? sbonazzo: planning_ack? sbonazzo: devel_ack+ cshao: testing_ack+
Target Release:	4.1
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: Grub config files were built in a wrong format. Consequence: Trying to install ovirt-node-ng from iso on a UEFI system failed in the grub menu. Fix: Changed the way we build the config files using a more strict regex Result: Grub menu in UEFI systems now displays correctly	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-06 14:04:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jimmy Martin 2017-05-31 19:40:02 UTC

Description of problem:
Booting from the Node installer isos uploaded will fail without manually editing Grub2 menu

Version-Release number of selected component (if applicable):
4.1 including current Master

How reproducible:
Every dang time

Steps to Reproduce:
1. Burn iso
2. Boot iso
3. Bam, FAIL!

Actual results:
Error loading grub menus and will eventually take you to recover an install that doesn't exist.

Expected results:
A menu to allow you to install

Additional info:
The Grub menu is malformed. Adding in the closing quote and starting brace in the menuoption will fix it.

Comment 1 Qin Yuan 2017-06-01 03:41:07 UTC

QE tried to burn RHVH-4.1-20170514.1-RHVH-x86_64-dvd1.iso and RHVH-4.1-20170523.1-RHVH-x86_64-dvd1.iso, respectively, using cdrecord command line. Both could install RHVH successfully.

Comment 2 Jimmy Martin 2017-06-01 03:45:50 UTC

Thank you for looking.

Try:

http://jenkins.ovirt.org/job/ovirt-node-ng_ovirt-4.1_build-artifacts-el7-x86_64/lastSuccessfulBuild/artifact/exported-artifacts/latest-installation-iso.html

Or any of the current Ovirt Node 4.1 build isos.

Comment 3 Qin Yuan 2017-06-01 10:12:24 UTC

Tried ovirt-node-ng-installer-ovirt-4.1-2017060104.iso, burned iso to DVD using cdrecord command line, installed ovirt-node-ng-4.1.2-0.20170601 successfully.

Comment 4 Yuval Turgeman 2017-06-01 12:40:47 UTC

This can be reproduces with UEFI, using virt-install -c <path_to_iso> --boot uefi

Comment 5 Jimmy Martin 2017-06-01 13:18:08 UTC

All of my lab machines are indeed UEFI boot.

Comment 6 Qin Yuan 2017-06-02 06:26:06 UTC

According to comment #4, QE tried to install ovirt-node-ng-installer-ovirt-4.1-2017060104.iso via virtual media on an UEFI machine, the issue can be reproduced.

Comment 7 Qin Yuan 2017-06-12 10:14:46 UTC

Test Versions:
ovirt-node-ng-installer-ovirt-4.1-2017061104.iso

Test Steps:
1. Launch virtual media and attach the iso on UEFI machine
2. Reboot machine and choose to boot from virtual CD

Test Results:
1. There are correct grub menus which can lead you to install.
2. Install could succeed.

This bug is fixed, set the status to VERIFIED.

Comment 8 Jimmy Martin 2017-06-12 14:07:58 UTC

Awesome, thank you all for working on this and making sure this works well with UEFI enabled machines for a good experience for many if not most users.