Bug 1463961 - [DOCS] Image Labels not processed when running oc create
Summary: [DOCS] Image Labels not processed when running oc create
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Documentation
Version: 3.3.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Michael Burke
QA Contact: Vladislav Walek
Vikram Goyal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-22 07:10 UTC by Vladislav Walek
Modified: 2020-08-13 09:26 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-25 17:28:56 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Vladislav Walek 2017-06-22 07:10:55 UTC
Description of problem:

When running the command 'oc create' the Image Labels from template doesn't go to the build config. 

It works on oscp 3.4 but not in 3.3.

Version-Release number of selected component (if applicable):
OpenShift Container Platform 3.3.1

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Ben Parees 2017-06-22 13:55:59 UTC
imagelabels for buildconfigs were not a supported field in 3.3.

Comment 3 Ben Parees 2017-06-23 18:29:43 UTC
our docs are incorrect, this feature should not have been described in the 3.3 docs, it was introduced in v3.4.1

Comment 4 Vladislav Walek 2017-06-26 06:26:32 UTC
Thank you Ben, can we transition the bug to the docs team to fix it? Thx

Comment 5 Vikram Goyal 2017-06-26 06:54:12 UTC
Hey Vladislav, it has already been transferred :)

Comment 6 Michael Burke 2017-06-26 19:05:07 UTC
Ben and Vladislav --


I removed the paragraph that starts with: "You can also use the BuildConfig.spec.output.imageLabels field" and the "Custom labels to be applied to built images" example. 

These were added here: 
https://github.com/openshift/openshift-docs/commit/b04413ba9390a64ccb3a1b887cb701fad379953f


See PR:
https://github.com/openshift/openshift-docs/pull/4654

Please let me know if the entire "Output Image Labels" section through "Using External Artifacts During a Build" section should come out. This Output Image Label section with table is present in 3.2,

Comment 7 Michael Burke 2017-07-24 15:43:37 UTC
Vladislav  Please take a look,

Comment 8 Vladislav Walek 2017-07-25 07:43:42 UTC
Hello Michael,

it is ok. Thank you

Comment 9 Michael Burke 2017-07-25 17:22:08 UTC
Merged. 
https://github.com/openshift/openshift-docs/pull/4654

Comment 10 Michael Burke 2017-07-25 17:28:56 UTC
Change to the 3.3 docs is live.
https://docs.openshift.com/container-platform/3.3/dev_guide/builds.html


Note You need to log in before you can comment on or make changes to this bug.