Bug 1463961 - [DOCS] Image Labels not processed when running oc create
[DOCS] Image Labels not processed when running oc create
Status: CLOSED CURRENTRELEASE
Product: OpenShift Container Platform
Classification: Red Hat
Component: Documentation (Show other bugs)
3.3.1
Unspecified Unspecified
low Severity low
: ---
: ---
Assigned To: Michael Burke
Vladislav Walek
Vikram Goyal
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-22 03:10 EDT by Vladislav Walek
Modified: 2017-07-25 13:28 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-25 13:28:56 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Vladislav Walek 2017-06-22 03:10:55 EDT
Description of problem:

When running the command 'oc create' the Image Labels from template doesn't go to the build config. 

It works on oscp 3.4 but not in 3.3.

Version-Release number of selected component (if applicable):
OpenShift Container Platform 3.3.1

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Ben Parees 2017-06-22 09:55:59 EDT
imagelabels for buildconfigs were not a supported field in 3.3.
Comment 3 Ben Parees 2017-06-23 14:29:43 EDT
our docs are incorrect, this feature should not have been described in the 3.3 docs, it was introduced in v3.4.1
Comment 4 Vladislav Walek 2017-06-26 02:26:32 EDT
Thank you Ben, can we transition the bug to the docs team to fix it? Thx
Comment 5 Vikram Goyal 2017-06-26 02:54:12 EDT
Hey Vladislav, it has already been transferred :)
Comment 6 Michael Burke 2017-06-26 15:05:07 EDT
Ben and Vladislav --


I removed the paragraph that starts with: "You can also use the BuildConfig.spec.output.imageLabels field" and the "Custom labels to be applied to built images" example. 

These were added here: 
https://github.com/openshift/openshift-docs/commit/b04413ba9390a64ccb3a1b887cb701fad379953f


See PR:
https://github.com/openshift/openshift-docs/pull/4654

Please let me know if the entire "Output Image Labels" section through "Using External Artifacts During a Build" section should come out. This Output Image Label section with table is present in 3.2,
Comment 7 Michael Burke 2017-07-24 11:43:37 EDT
Vladislav  Please take a look,
Comment 8 Vladislav Walek 2017-07-25 03:43:42 EDT
Hello Michael,

it is ok. Thank you
Comment 9 Michael Burke 2017-07-25 13:22:08 EDT
Merged. 
https://github.com/openshift/openshift-docs/pull/4654
Comment 10 Michael Burke 2017-07-25 13:28:56 EDT
Change to the 3.3 docs is live.
https://docs.openshift.com/container-platform/3.3/dev_guide/builds.html

Note You need to log in before you can comment on or make changes to this bug.