Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-8tracks.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-8tracks-5.2-1.fc25.src.rpm Description: Integration of 8tracks into your linux desktop via Nuvola Player. Fedora Account System Username: martinkg rpmlint -i -v nuvola-app-8tracks.spec /home/martin/rpmbuild/SRPMS/nuvola-app-8tracks-5.2-1.fc25.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-8tracks-5.2-1.fc25.noarch.rpm nuvola-app-8tracks.spec: I: checking nuvola-app-8tracks.spec:30: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-8tracks.spec: I: checking-url https://github.com/tiliado/nuvola-app-8tracks/archive/5.2.tar.gz#/nuvola-app-8tracks-5.2.tar.gz (timeout 10 seconds) nuvola-app-8tracks.src: I: checking nuvola-app-8tracks.src: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-8tracks.src: I: checking-url https://github.com/tiliado/nuvola-app-8tracks (timeout 10 seconds) nuvola-app-8tracks.src:30: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-8tracks.src: I: checking-url https://github.com/tiliado/nuvola-app-8tracks/archive/5.2.tar.gz#/nuvola-app-8tracks-5.2.tar.gz (timeout 10 seconds) nuvola-app-8tracks.noarch: I: checking nuvola-app-8tracks.noarch: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-8tracks.noarch: I: checking-url https://github.com/tiliado/nuvola-app-8tracks (timeout 10 seconds) nuvola-app-8tracks.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaApp8tracks.desktop nuvola the .desktop file is for a file not present in the package. You should check the requires or see if this is not a error 2 packages and 1 specfiles checked; 0 errors, 5 warnings. %changelog * Mon Jun 26 2017 Martin Gansser <martinkg> - 5.2-1 - Update to 5.2-1 * Mon Jan 23 2017 Martin Gansser <martinkg> - 5.1-1 - initial build
*** Bug 1476291 has been marked as a duplicate of this bug. ***
correct links for the rpm packages: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-8tracks.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-8tracks-5.2-1.fc26.src.rpm
I'll take this for a review.
* Typo in .metainfo.xml - s/Intergration/Integration/ - But it would be probably better to drop the suffix entirely, since I don't see any purpose in it. Otherwise, the package looks good => APPROVE
Thanks for the review. %changelog * Fri Aug 04 2017 Martin Gansser <martinkg> - 5.2-2 - correct %%{name}.metainfo.xml
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-8tracks
package has been built successfully on f25, f26 and rawhide.