Bug 1466787 - Review Request: perl-MooX-StrictConstructor - Make your Moo-based object constructors blow up on unknown attributes
Review Request: perl-MooX-StrictConstructor - Make your Moo-based object cons...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 1467371
  Show dependency treegraph
 
Reported: 2017-06-30 08:55 EDT by Jitka Plesnikova
Modified: 2017-07-03 11:51 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-MooX-StrictConstructor-0.008-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-03 11:51:00 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2017-06-30 08:55:37 EDT
Spec URL: https://jplesnik.fedorapeople.org/perl-MooX-StrictConstructor/perl-MooX-StrictConstructor.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-MooX-StrictConstructor/perl-MooX-StrictConstructor-0.008-1.fc27.src.rpm

Description:
Simply loading this module makes your constructors "strict". If your
constructor is called with an attribute init argument that your class does
not declare, then it dies. This is a great way to catch small typos.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2017-07-03 11:13:59 EDT
URL and Source0 addresses are Ok.
Source archive (SHA-256: bf1ff7b5d22e9fbaa37eafaa7bdef1997fbd853f1d893ebdcf75a360e67081ac) is original. Ok.
Summary verified from lib/MooX/StrictConstructor.pm. Ok.
Description verified from lib/MooX/StrictConstructor.pm. Ok.
License verified from lib/Method/Generate/Constructor/Role/StrictConstructor.pm, lib/MooX/StrictConstructor.pm, and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.
Pod::Coverage::TrustPod, Test::CPAN::Meta and Test::Pod not used. Ok.
All tests pass. Ok.


$ rpmlint perl-MooX-StrictConstructor.spec ../SRPMS/perl-MooX-StrictConstructor-0.008-1.fc27.src.rpm ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm 
perl-MooX-StrictConstructor.src: W: spelling-error %description -l en_US init -> unit, int, nit
perl-MooX-StrictConstructor.noarch: W: spelling-error %description -l en_US init -> unit, int, nit
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul  3 17:05 /usr/share/doc/perl-MooX-StrictConstructor
-rw-r--r--    1 root    root                     1265 May 11  2015 /usr/share/doc/perl-MooX-StrictConstructor/Changes
drwxr-xr-x    2 root    root                        0 Jul  3 17:05 /usr/share/licenses/perl-MooX-StrictConstructor
-rw-r--r--    1 root    root                    18358 May 11  2015 /usr/share/licenses/perl-MooX-StrictConstructor/LICENSE
-rw-r--r--    1 root    root                     1518 Jul  3 17:05 /usr/share/man/man3/Method::Generate::Constructor::Role::StrictConstructor.3pm.gz
-rw-r--r--    1 root    root                     2584 Jul  3 17:05 /usr/share/man/man3/MooX::StrictConstructor.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul  3 17:05 /usr/share/perl5/vendor_perl/Method
drwxr-xr-x    2 root    root                        0 Jul  3 17:05 /usr/share/perl5/vendor_perl/Method/Generate
drwxr-xr-x    2 root    root                        0 Jul  3 17:05 /usr/share/perl5/vendor_perl/Method/Generate/Constructor
drwxr-xr-x    2 root    root                        0 Jul  3 17:05 /usr/share/perl5/vendor_perl/Method/Generate/Constructor/Role
-rw-r--r--    1 root    root                     2164 May 11  2015 /usr/share/perl5/vendor_perl/Method/Generate/Constructor/Role/StrictConstructor.pm
drwxr-xr-x    2 root    root                        0 Jul  3 17:05 /usr/share/perl5/vendor_perl/MooX
-rw-r--r--    1 root    root                     4405 May 11  2015 /usr/share/perl5/vendor_perl/MooX/StrictConstructor.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(B)
      1 perl(Class::Method::Modifiers)
      1 perl(constant)
      1 perl(Moo) >= 1.001000
      1 perl(Moo::Role)
      1 perl(strict)
      1 perl(strictures) >= 1
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl(feature)' (lib/Method/Generate/Constructor/Role/StrictConstructor.pm:27).

$ rpm -q --provides -p ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Method::Generate::Constructor::Role::StrictConstructor) = 0.008
      1 perl(MooX::StrictConstructor) = 0.008
      1 perl-MooX-StrictConstructor = 0.008-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide  ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20307931). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item before building this package.
Resolution: Package APPROVED.
Comment 2 Gwyn Ciesla 2017-07-03 11:32:42 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MooX-StrictConstructor
Comment 3 Jitka Plesnikova 2017-07-03 11:51:00 EDT
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.