Bug 1469404 - Review Request: perl-Locale-TextDomain-OO-Util - Lexical Utils for Locale::TextDomain::OO
Review Request: perl-Locale-TextDomain-OO-Util - Lexical Utils for Locale::Te...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-11 04:35 EDT by Jitka Plesnikova
Modified: 2017-07-12 06:25 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-Locale-TextDomain-OO-Util-3.006-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-12 06:25:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2017-07-11 04:35:18 EDT
Spec URL: https://jplesnik.fedorapeople.org/perl-Locale-TextDomain-OO-Util/perl-Locale-TextDomain-OO-Util.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Locale-TextDomain-OO-Util/perl-Locale-TextDomain-OO-Util-3.006-1.fc27.src.rpm

Description:
This modules provide methods for lexicon constants, to join and split
lexicon keys and to extract the gettext file header.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2017-07-11 09:44:56 EDT
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 0175157c064cf9dd483421a32ed6b537dab61afd51394bd8da5bacafa68172ae) is original. Ok.
Summary is Ok.
Description verified from lib/Locale/TextDomain/OO/Util.pm.

FIX: Correct the determiner in the description `This modules'.

License verified from lib/Locale/TextDomain/OO/Util/JoinSplitLexiconKeys.pm, lib/Locale/TextDomain/OO/Util/Constants.pm, lib/Locale/TextDomain/OO/Util/JavaScript.pm, lib/Locale/TextDomain/OO/Util/ExtractHeader.pm, lib/Locale/TextDomain/OO/Util.pm, and README. Ok.
No XS codem noarch BuildArch is Ok.
Clone not used. Ok.
Test::Prereq::Build not used. Ok.
Test::Perl::Critic not used. Ok.

FIX: Either package the javascript directory as a subackage per <https://fedoraproject.org/wiki/Packaging:JavaScript> or remove JavaScript.pm from this package as it's only purpose is to be a documentation for the javascript files.

All tests pass. Ok.

$ rpmlint perl-Locale-TextDomain-OO-Util.spec ../SRPMS/perl-Locale-TextDomain-OO-Util-3.006-1.fc27.src.rpm ../RPMS/noarch/perl-Locale-TextDomain-OO-Util-3.006-1.fc27.noarch.rpm 
perl-Locale-TextDomain-OO-Util.src: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette
perl-Locale-TextDomain-OO-Util.noarch: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Locale-TextDomain-OO-Util-3.006-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 11 15:38 /usr/share/doc/perl-Locale-TextDomain-OO-Util
-rw-r--r--    1 root    root                     1190 Jul 11 15:38 /usr/share/doc/perl-Locale-TextDomain-OO-Util/Changes
-rw-r--r--    1 root    root                      640 Jul 11 15:38 /usr/share/doc/perl-Locale-TextDomain-OO-Util/README
drwxr-xr-x    2 root    root                        0 Jul 11 15:38 /usr/share/doc/perl-Locale-TextDomain-OO-Util/example
-rw-r--r--    1 root    root                      859 Jul 11 15:38 /usr/share/doc/perl-Locale-TextDomain-OO-Util/example/01_constants.pl
-rw-r--r--    1 root    root                     6084 Jul 11 15:38 /usr/share/doc/perl-Locale-TextDomain-OO-Util/example/02_join_split.pl
-rw-r--r--    1 root    root                      839 Jul 11 15:38 /usr/share/doc/perl-Locale-TextDomain-OO-Util/example/03_extract_header.pl
-rw-r--r--    1 root    root                     1782 Jul 11 15:38 /usr/share/man/man3/Locale::TextDomain::OO::Util.3pm.gz
-rw-r--r--    1 root    root                     1859 Jul 11 15:38 /usr/share/man/man3/Locale::TextDomain::OO::Util::Constants.3pm.gz
-rw-r--r--    1 root    root                     2140 Jul 11 15:38 /usr/share/man/man3/Locale::TextDomain::OO::Util::ExtractHeader.3pm.gz
-rw-r--r--    1 root    root                     2011 Jul 11 15:38 /usr/share/man/man3/Locale::TextDomain::OO::Util::JavaScript.3pm.gz
-rw-r--r--    1 root    root                     2329 Jul 11 15:38 /usr/share/man/man3/Locale::TextDomain::OO::Util::JoinSplitLexiconKeys.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 11 15:38 /usr/share/perl5/vendor_perl/Locale
drwxr-xr-x    2 root    root                        0 Jul 11 15:38 /usr/share/perl5/vendor_perl/Locale/TextDomain
drwxr-xr-x    2 root    root                        0 Jul 11 15:38 /usr/share/perl5/vendor_perl/Locale/TextDomain/OO
drwxr-xr-x    2 root    root                        0 Jul 11 15:38 /usr/share/perl5/vendor_perl/Locale/TextDomain/OO/Util
-rw-r--r--    1 root    root                     1689 Feb 23 07:18 /usr/share/perl5/vendor_perl/Locale/TextDomain/OO/Util.pm
-rw-r--r--    1 root    root                     2411 Jun 29  2015 /usr/share/perl5/vendor_perl/Locale/TextDomain/OO/Util/Constants.pm
-rw-r--r--    1 root    root                     5920 Feb 23 07:51 /usr/share/perl5/vendor_perl/Locale/TextDomain/OO/Util/ExtractHeader.pm
-rw-r--r--    1 root    root                     2237 Jun 29  2015 /usr/share/perl5/vendor_perl/Locale/TextDomain/OO/Util/JavaScript.pm
-rw-r--r--    1 root    root                     6937 Jun 29  2015 /usr/share/perl5/vendor_perl/Locale/TextDomain/OO/Util/JoinSplitLexiconKeys.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Locale-TextDomain-OO-Util-3.006-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Carp)
      1 perl(charnames)
      1 perl(English)
      1 perl(Locale::TextDomain::OO::Util::Constants)
      1 perl(namespace::autoclean)
      1 perl(Safe)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Locale-TextDomain-OO-Util-3.006-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Locale::TextDomain::OO::Util) = 3.006
      1 perl(Locale::TextDomain::OO::Util::Constants) = 3.004
      1 perl(Locale::TextDomain::OO::Util::ExtractHeader) = 3.006
      1 perl(Locale::TextDomain::OO::Util::JavaScript) = 3.004
      1 perl(Locale::TextDomain::OO::Util::JoinSplitLexiconKeys) = 3.004
      1 perl-Locale-TextDomain-OO-Util = 3.006-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Locale-TextDomain-OO-Util-3.006-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20459862). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' items before building this package.
Resolution: Package APPROVED.
Comment 2 Gwyn Ciesla 2017-07-11 12:00:42 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Locale-TextDomain-OO-Util

Note You need to log in before you can comment on or make changes to this bug.