Bug 1469479 - Review Request: perl-Locale-Utils-PlaceholderBabelFish - Utils to expand BabelFish placeholders
Review Request: perl-Locale-Utils-PlaceholderBabelFish - Utils to expand Babe...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-11 07:09 EDT by Jitka Plesnikova
Modified: 2017-07-12 07:25 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-12 07:25:20 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Comment 1 Petr Pisar 2017-07-12 03:48:23 EDT
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: ae54eeb899c844441abbdc6188205e8067dcb52f5862fca79d297e1091f24f95) is original. Ok.
Summary verified from lib/Locale/Utils/PlaceholderBabelFish.pm. Ok.
Description verified from lib/Locale/Utils/PlaceholderBabelFish.pm. Ok.
License verified from lib/Locale/Utils/PlaceholderBabelFish.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
Test::Perl::Critic and Test::Prereq::Build not used. Ok.
All tests pass. Ok.

$ rpmlint perl-Locale-Utils-PlaceholderBabelFish.spec ../SRPMS/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.src.rpm ../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 12 09:18 /usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish
-rw-r--r--    1 root    root                      400 Jul 12 09:18 /usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/Changes
-rw-r--r--    1 root    root                      668 Jul 12 09:18 /usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/README
drwxr-xr-x    2 root    root                        0 Jul 12 09:18 /usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/example
-rw-r--r--    1 root    root                     2560 Jul 12 09:18 /usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/example/01_expand_babel_fish.pl
-rw-r--r--    1 root    root                     2856 Jul 12 09:18 /usr/share/man/man3/Locale::Utils::PlaceholderBabelFish.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 12 09:18 /usr/share/perl5/vendor_perl/Locale
drwxr-xr-x    2 root    root                        0 Jul 12 09:18 /usr/share/perl5/vendor_perl/Locale/Utils
-rw-r--r--    1 root    root                     9062 Feb 24 08:05 /usr/share/perl5/vendor_perl/Locale/Utils/PlaceholderBabelFish.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Carp)
      1 perl(HTML::Entities)
      1 perl(List::Util)
      1 perl(Moo) >= 1.003001
      1 perl(MooX::StrictConstructor)
      1 perl(MooX::Types::MooseLike::Base)
      1 perl(namespace::autoclean)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Locale::Utils::PlaceholderBabelFish) = 0.004
      1 perl-Locale-Utils-PlaceholderBabelFish = 0.004-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20472052). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
Comment 2 Gwyn Ciesla 2017-07-12 06:59:33 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Locale-Utils-PlaceholderBabelFish
Comment 3 Jitka Plesnikova 2017-07-12 07:25:20 EDT
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.