Bug 1470305 - RFE: drop hgdistver dependency
Summary: RFE: drop hgdistver dependency
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-execnet
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Thomas Moschny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-12 17:17 UTC by Ken Dreyer
Modified: 2017-07-16 02:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-15 11:12:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
drop hgdistver in rawhide (1.94 KB, patch)
2017-07-12 17:30 UTC, Ken Dreyer
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1208984 0 unspecified CLOSED get_version_from_scm=True in setup.py results in 0.0.0 module version 2021-02-22 00:41:40 UTC

Internal Links: 1208984

Description Ken Dreyer 2017-07-12 17:17:45 UTC
Description of problem:
We can slim down the build dependencies of python-execnet by dropping BuildRequires: python-hgdistver and python3-hgdistver and using the SETUPTOOLS_SCM_PRETEND_VERSION environment variable instead during the %build and %install steps.

Version-Release number of selected component (if applicable):
python-execnet-1.4.1-5.fc26

Comment 1 Ken Dreyer 2017-07-12 17:30:49 UTC
Created attachment 1297138 [details]
drop hgdistver in rawhide

I've verified that this satisfies the test case from the earlier BZ 1208984:

  $ cat etest.py 
  #!/usr/bin/python
  from pkg_resources import require
  require('execnet>=1.1dev1')

This require statement does not raise, and hgdistver is not installed in my environment.

You can pull the changes from my Git fork here or apply the patch I'm attaching to this BZ.

The following changes since commit 78984c1be4dba71dc61444f7860c1457d5635b23:

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild (2017-02-11 08:57:50 +0000)

are available in the git repository at:

  git://fedorapeople.org/home/fedora/ktdreyer/public_git/python-execnet.git 

for you to fetch changes up to b38896acf0a4e4674dc4af64df0f0a0033c5f592:

  drop hgdistver dependency by overriding setuptools-scm version (2017-07-12 11:21:57 -0600)

----------------------------------------------------------------
Ken Dreyer (1):
      drop hgdistver dependency by overriding setuptools-scm version

 python-execnet.spec | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comment 2 Thomas Moschny 2017-07-15 11:12:25 UTC
Thanks for the patch! Applied and built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=918965

Comment 3 Ken Dreyer 2017-07-16 02:20:09 UTC
Awesome, thanks Thomas!


Note You need to log in before you can comment on or make changes to this bug.