Red Hat Bugzilla – Bug 1470747
fixing harmful typos in databases/mysql/general-changes/check
Last modified: 2017-08-01 20:10:57 EDT
Description of problem:
Backticks in place of single quotes caused module to hang, waiting for output of non-existing commands
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Fixed. Now the module works as expected
Notes for QA
This should reproduce the issue (according to info from @bnater, who originally reproduced it on in-place upgrade workshop).
echo 'DROP DATABASE php_mysql_test;'
echo 'CREATE DATABASE php_mysql_test;'
echo 'USE php_mysql_test;'
echo 'CREATE TABLE foobar (name VARCHAR(10), value INTEGER);'
echo 'INSERT INTO foobar VALUES("fish", 42);'
} | mysql --verbose -u root
...and preupg will get stuck at mysql module mysql/general_changes.
Also, make sure to review the patch:
(Correcting Alois Mahdal's comment #3)
> Notes for QA
> This should reproduce the issue (according to info from @bnater, who
> originally reproduced it on in-place upgrade workshop).
Of course, first:
yum -y install mysql mysql-server
service mysql start
> echo 'DROP DATABASE php_mysql_test;'
> echo 'CREATE DATABASE php_mysql_test;'
> echo 'USE php_mysql_test;'
> echo 'CREATE TABLE foobar (name VARCHAR(10), value INTEGER);'
> echo 'INSERT INTO foobar VALUES("fish", 42);'
> } | mysql --verbose -u root
> preupg --force
Turns out that /CoreOS/preupgrade-assistant-el6toel7/upg/mysql-sanity reproduces this as well, so I used that instead of the above STR.
* TJ#1959725 preupgrade-assistant-el6toel7-0.6.70-2.el6 - is still
stuck at the mysql module.
* TJ#1959724 preupgrade-assistant-el6toel7-0.6.71-2.el6 - has already
finished and passed.
* I have reviewed the texts and terms are now quoted using apostrophes.
* I have also reviewed the patch -- looks OK.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.