Bug 1472201 - %kernel_module_package not actually honor %kmodtool_generate_buildreqs
%kernel_module_package not actually honor %kmodtool_generate_buildreqs
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Florian Festi
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-18 05:09 EDT by Robin Lee
Modified: 2017-07-18 08:51 EDT (History)
6 users (show)

See Also:
Fixed In Version: redhat-rpm-config-66-1.fc27.src.rpm
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-18 08:51:19 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch proposed to fix this issue. (879 bytes, patch)
2017-07-18 05:09 EDT, Robin Lee
no flags Details | Diff

  None (edit)
Description Robin Lee 2017-07-18 05:09:14 EDT
Created attachment 1300336 [details]
Patch proposed to fix this issue.

Description of problem:
No matter what %kmodtool_generate_buildreqs is defined, BuildRequires will be always generated.

The fix is simple, and the patch is attached.

Version-Release number of selected component (if applicable):
kernel-rpm-macros-63-1.fc26.noarch

How reproducible:
Always

Actual results:
No matter what %kmodtool_generate_buildreqs is defined, BuildRequires will be always generated.

Expected results:
When %kmodtool_generate_buildreqs is not defined or defined to '0', BuildRequires will not be generated.
Comment 1 Florian Festi 2017-07-18 06:31:23 EDT
Hmm, were is nobuildreqs="yes" set with the proposed patch? I have the sneaking suspicion that this patch breaks the normal use case.
Comment 2 Robin Lee 2017-07-18 06:44:57 EDT
kmodtool actually checks for 'no', not for 'yes'. That meas setting %nobuildreqs to 'yes' or anything other than 'no' has the same effect.
Comment 3 Florian Festi 2017-07-18 08:51:19 EDT
Added a nobuildreqs="yes" line just for good measures.

Note You need to log in before you can comment on or make changes to this bug.