Description of problem: kickpim does not build on x86_64; See: http://fedoraproject.org/extras/3/build-logs/x86_64/kickpim.log Version-Release number of selected component (if applicable): 0.5.3-4 Additional info: Fixed by the attached patch. Rex any comments on it? Would it be okay for you if we would apply it to CVS?
Created attachment 110717 [details] spec patch that fixes building on x86_64
Why add -DPIC too, instead of just -fPIC as the build log suggested? What is meant by the changelog comment: "using the configure option does not fix it"? That setting CXXFLAGS before configure didn't work? Like: %ifarch x86_64 export CXXFLAGS="-fPIC $RPM_OPT_FLAGS" %endif %configure ...
Created attachment 110723 [details] specfile patch - fix x86_64 build - tighten kdelibs dep - cleanup %%configure
This way, %%configure uses the same compiler flags as the 'make' step does. Also snuck in a few other minor improvements. If it turns out -DPIC really is needed too, feel free to add that too.
(In reply to comment #2) > Why add -DPIC too, instead of just -fPIC as the build log suggested? Someone mentioned that this should be done this way, but I can't remember where. And I saw mschendt using it also: https://www.redhat.com/archives/fedora-extras-commits/2005-February/msg00095.html But I don't know the details :( >What is meant by the changelog comment: "using the configure option does not >fix it"? That setting CXXFLAGS before configure didn't work? Sorry, trimmed it to much; there is a configure option --with-pic / --without-pic. But it does not work. (In reply to comment #3) > Created an attachment (id=110723) [edit] > specfile patch Thanks Rex. Yes, this also fixes build on x86-64.
No need to worry. -DPIC is probably redundant, bad habit, but still used by libtool and might be that some software ifdefs PIC. No time to investigate. If memory serves correctly, -fPIC internally sets -D__PIC__ already.
Commited attachment (id=110723) to CVS and requested build. Thanks Rex.