Bug 1475026 - Please better document base.group_install API change
Please better document base.group_install API change
Status: NEW
Product: Fedora
Classification: Fedora
Component: dnf (Show other bugs)
26
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Igor Gnatenko
Fedora Extras Quality Assurance
: Documentation, Triaged
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-25 17:20 EDT by Jason Tibbitts
Modified: 2017-07-26 07:33 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Jason Tibbitts 2017-07-25 17:20:50 EDT
There was a bit of compat code from upstream commit fdacdb85533721396789c6185b06a3a1e8148292 which went away in dnf-2 that allowed base.group_install to accept a base.comp.Group object as its first argument instead of a string.  Unfortunately the "Changes in DNF-2 compared to DNF-1" document says only:

"
Following API methods accept different arguments
[...]
    dnf.Base.group_install()
"

I had assumed that the change was only the addition of the third optional argument, but it's actually a bit more significant and unfortunately this broke Ansible's DNF module.

I guess there's no undoing the change, but it would be nice to have it more fully documented.  I'd argue that a warning on the improper API usage would have been good as well, but it's a bit late for that now.

Note You need to log in before you can comment on or make changes to this bug.