Bug 1476236 - need a consistent style for output
Summary: need a consistent style for output
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Maciej Szulik
QA Contact: Xingxing Xia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-28 11:39 UTC by Weihua Meng
Modified: 2019-08-21 09:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-21 09:12:48 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Weihua Meng 2017-07-28 11:39:40 UTC
Description of problem:
If we have a good and consistent style of output, it is good for user to understand and would help for automation.

Version-Release number of selected component (if applicable):
openshift v3.6.172.0.0

How reproducible:
Always

Steps to Reproduce:
1. when create pod, the output is 
pod "hello-pod" created
or if failed
The Pod "pod-toleration-fail" is invalid:
why we upper case 'P' for pod here?

2. for detailed info, we got
The Pod "pod-toleration-fail" is invalid: spec.tolerations[0].operator: Invalid value: api.Toleration{Key:"vip", Operator:"Exists", Value:"value123", Effect:"NoSchedule", TolerationSeconds:(*int64)(nil)}: value must be empty when `operator` is 'Exists'
and
The Pod "pod-toleration-fail-no-key" is invalid: spec.tolerations[0].operator: Invalid value: "Equal": operator must be Exists when `key` is empty, which means "match all values and all keys"
if '$keyword' style is used, it should be consistent. (`operator`, 'Exists')
`operator` and operator should have different meanings by common sense, or users are confused.
Consistent style is also helpful for automation. 


Actual results:


Expected results:


Additional info:

Comment 1 Maciej Szulik 2019-08-21 09:12:48 UTC
This was addressed when introducing common printing scheme inside kubectl.


Note You need to log in before you can comment on or make changes to this bug.