Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-jango.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-jango-2.3-1.fc26.src.rpm Description: Integration of Jango into your linux desktop via Nuvola Player. Fedora Account System Username: martinkg rpmlint -i -v nuvola-app-jango.spec /home/martin/rpmbuild/SRPMS/nuvola-app-jango-2.3-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-jango-2.3-1.fc26.noarch.rpm nuvola-app-jango.spec: I: checking nuvola-app-jango.spec:30: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-jango.spec: I: checking-url https://github.com/tiliado/nuvola-app-jango/archive/2.3.tar.gz#/nuvola-app-jango-2.3.tar.gz (timeout 10 seconds) nuvola-app-jango.src: I: checking nuvola-app-jango.src: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-jango.src: I: checking-url https://github.com/tiliado/nuvola-app-jango (timeout 10 seconds) nuvola-app-jango.src:30: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-jango.src: I: checking-url https://github.com/tiliado/nuvola-app-jango/archive/2.3.tar.gz#/nuvola-app-jango-2.3.tar.gz (timeout 10 seconds) nuvola-app-jango.noarch: I: checking nuvola-app-jango.noarch: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-jango.noarch: I: checking-url https://github.com/tiliado/nuvola-app-jango (timeout 10 seconds) nuvola-app-jango.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppJango.desktop nuvola the .desktop file is for a file not present in the package. You should check the requires or see if this is not a error 2 packages and 1 specfiles checked; 0 errors, 5 warnings.
Taking this for a review.
* Description - Please drop the "Mixcloud for Nuvola Player 3 : " from the description. This is already contained in summary. No need to repeat it. * .metainfo.xml typo in summary - s/Jano/Jango/ These are minor nits, so I APPROVE the package, but please fix them prior importing into Fedora.
(In reply to Vít Ondruch from comment #2) > * Description > - Please drop the "Mixcloud for Nuvola Player 3 : " from the description. > This > is already contained in summary. No need to repeat it. There is no text "Mixcloud for Nuvola Player 3 :" i can drop from description. :) > > * .metainfo.xml typo in summary > - s/Jano/Jango/ > > These are minor nits, so I APPROVE the package, but please fix them prior > importing into Fedora. new rpm packages: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-jango.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-jango- 2.3-2.fc26.src.rpm %changelog * Thu Aug 10 2017 Martin Gansser <martinkg> - 2.3-2 - correct %%{name}.metainfo.xml
(In reply to mgansser from comment #3) > (In reply to Vít Ondruch from comment #2) > > * Description > > - Please drop the "Mixcloud for Nuvola Player 3 : " from the description. > > This > > is already contained in summary. No need to repeat it. > > There is no text "Mixcloud for Nuvola Player 3 :" i can drop from > description. :) Ahh, silly me. Sorry for the confusion ....
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-jango
package has been built successfully on f25, f26 and rawhide.