Bug 1478855 - When pipeline stage is canceled, stage icon is better to show canceled instead of failed
When pipeline stage is canceled, stage icon is better to show canceled instea...
Status: CLOSED NOTABUG
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console (Show other bugs)
3.6.0
Unspecified Unspecified
medium Severity low
: ---
: 3.7.0
Assigned To: Samuel Padgett
XiaochuanWang
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-07 06:38 EDT by Xingxing Xia
Modified: 2017-08-07 08 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-08-07 08:34:54 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
aborted stage icon (114.10 KB, image/png)
2017-08-07 06:38 EDT, Xingxing Xia
no flags Details
Jenkins shows the stage as failed as well (135.15 KB, image/png)
2017-08-07 08:35 EDT, Samuel Padgett
no flags Details

  None (edit)
Description Xingxing Xia 2017-08-07 06:38:17 EDT
Description of problem:
When pipeline stage is canceled, stage icon now is shown failed. It is better to show canceled instead of failed

Version-Release number of selected component (if applicable):
v3.6.173.0.5

How reproducible:
Always

Steps to Reproduce:
1. Create pipeline
$ oc new-app -f https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/pipeline/samplepipeline.yaml
2. Define "input" step in jenkinsfile on web console by adding steps 'input message' as stages
...
      jenkinsfile: |-
...
        stage('stage1') {
        input message: 'really approve?'
        }
        stage('stage2') {
        input message: 'really approve?'
        }
...


3. Start pipeline. When web prompts "Input Required", click it and select Abort in following page

4. Check the pipeline build's status icon
Check the aborted stage icon

Actual results:
4. The pipeline build's status icon is shown as canceled.
But the aborted stage icon is shown as failed.
See screenshot. The element inspector shows "FAILED" for canceled stage

Expected results:
4. Both should be shown as canceled, as screenshot in https://github.com/openshift/origin-web-console/pull/188 designed for card https://trello.com/c/VgmHJvYQ/676-1-manual-approval-stages-in-pipelines

Additional info:
Comment 1 Xingxing Xia 2017-08-07 06:38 EDT
Created attachment 1310018 [details]
aborted stage icon
Comment 2 Samuel Padgett 2017-08-07 08:34:54 EDT
Jenkins reports the stage status to us as "Failed" and shows the same icon in the Jenkins user interface. I agree it's a little odd, but I'd rather be consistent with Jenkins.
Comment 3 Samuel Padgett 2017-08-07 08:35 EDT
Created attachment 1310035 [details]
Jenkins shows the stage as failed as well

Note You need to log in before you can comment on or make changes to this bug.