Bug 1480130 - Review Request: perl-Math-Utils - Useful mathematical functions not in Perl
Review Request: perl-Math-Utils - Useful mathematical functions not in Perl
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 1480032
  Show dependency treegraph
 
Reported: 2017-08-10 05:14 EDT by Jitka Plesnikova
Modified: 2017-08-14 02:45 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-Math-Utils-1.10-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-08-14 02:45:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2017-08-10 05:14:55 EDT
Spec URL: https://jplesnik.fedorapeople.org/perl-Math-Utils/perl-Math-Utils.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Math-Utils/perl-Math-Utils-1.10-1.fc27.src.rpm

Description:
Math::Utils contains implementations of commonly used mathematical
functions and operations that are not part of standard Perl.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2017-08-10 05:39:16 EDT
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 0905aab8b65ed08f951756dd86803267877f88e45027af458bb3b83d218cb7c4) is original. Ok.
Summary verified in lib/Math/Utils.pm. Ok.
Description is Ok.
License verified in lib/Math/Utils.pm and README. The LICENSE file seems bogus (CPAN RT#122758). Ok.
No XS code, noarch BuildArch is Ok.
Test::CheckManifest not used. Ok.
All tests pass. Ok.

$ rpmlint perl-Math-Utils.spec ../SRPMS/perl-Math-Utils-1.10-1.fc27.src.rpm ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Aug 10 11:34 /usr/share/doc/perl-Math-Utils
-rw-r--r--    1 root    root                     3290 May 11 02:07 /usr/share/doc/perl-Math-Utils/Changes
-rw-r--r--    1 root    root                     2754 May 11 02:08 /usr/share/doc/perl-Math-Utils/README
-rw-r--r--    1 root    root                     6423 Aug 10 11:34 /usr/share/man/man3/Math::Utils.3pm.gz
drwxr-xr-x    2 root    root                        0 Aug 10 11:34 /usr/share/perl5/vendor_perl/Math
-rw-r--r--    1 root    root                    18759 Aug 10 11:34 /usr/share/perl5/vendor_perl/Math/Utils.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(integer)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Math::Utils) = 1.09
      1 perl-Math-Utils = 1.10-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=21145375). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
Comment 2 Ralph Bean 2017-08-10 13:30:32 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Math-Utils
Comment 3 Ralph Bean 2017-08-10 13:31:00 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Math-Utils

Note You need to log in before you can comment on or make changes to this bug.