Bug 1483796 - Include and own /usr/lib64/qemu contents in librbd1, don't create in %post
Summary: Include and own /usr/lib64/qemu contents in librbd1, don't create in %post
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ceph
Version: 28
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Boris Ranto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-22 02:19 UTC by Ville Skyttä
Modified: 2019-04-30 09:41 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-04-30 09:41:16 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Include and own /usr/lib64/qemu contents in librbd1, don't create in %post (1.82 KB, patch)
2017-08-22 02:19 UTC, Ville Skyttä 		no flags Details | Diff
View All

Description Ville Skyttä 2017-08-22 02:19:19 UTC 
Untested 'git am'able fix attached, let me know if you'd like me to
push and build this for devel.
Comment 1 Ville Skyttä 2017-08-22 02:19:27 UTC 
Created attachment 1316495 [details]
Include and own /usr/lib64/qemu contents in librbd1, don't create in %post
Comment 2 Boris Ranto 2017-08-22 20:22:04 UTC 
Could you please create an upstream PR [1]? We consume the spec file for fedora from the upstream spec file and keeping as little changes as possible to the upstream spec file is highly preferred. It will also get a proper review.

Thanks,
Boris

[1] https://github.com/ceph/ceph/blob/master/ceph.spec.in
Comment 3 Ville Skyttä 2017-08-23 07:18:40 UTC 
https://github.com/ceph/ceph/pull/17181
Comment 4 Ademar Reis 2017-08-23 14:56:33 UTC 
This symlink should not be necessary anymore. QEMU is properly linked to ceph/librbd these days (look at the qemu-block-rbd sub-package in Fedora)

The symlink was a hack from a time when librbd was distributed and supported by ceph and the rbd driver would be enabled at runtime only when/if the symlink was present.

So the right fix is to actually get rid of the symlink altogether and never touch (much less own) /usr/lib64/qemu.
Comment 5 Fedora End Of Life 2018-02-20 15:27:11 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.
Comment 6 Boris Ranto 2019-04-30 09:41:16 UTC 
This was fixed when we switched to direct compilation against librbd in qemu.
Note You need to log in before you can comment on or make changes to this bug.