Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-jupiter-broadcasting.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-jupiter-broadcasting-1.1-1.fc26.src.rpm Description: Integration of Jupiter Broadcasting into your linux desktop via Nuvola Player. Fedora Account System Username: martinkg rpmlint -i -v nuvola-app-jupiter-broadcasting.spec /home/martin/rpmbuild/SRPMS/nuvola-app-jupiter-broadcasting-1.1-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-jupiter-broadcasting-1.1-1.fc26.noarch.rpm nuvola-app-jupiter-broadcasting.spec: I: checking nuvola-app-jupiter-broadcasting.spec:31: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-jupiter-broadcasting.spec: I: checking-url https://github.com/tiliado/nuvola-app-jupiter-broadcasting/archive/1.1.tar.gz#/nuvola-app-jupiter-broadcasting-1.1.tar.gz (timeout 10 seconds) nuvola-app-jupiter-broadcasting.src: I: checking nuvola-app-jupiter-broadcasting.src: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-jupiter-broadcasting.src: I: checking-url https://github.com/tiliado/nuvola-app-jupiter-broadcasting (timeout 10 seconds) nuvola-app-jupiter-broadcasting.src:31: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-jupiter-broadcasting.src: I: checking-url https://github.com/tiliado/nuvola-app-jupiter-broadcasting/archive/1.1.tar.gz#/nuvola-app-jupiter-broadcasting-1.1.tar.gz (timeout 10 seconds) nuvola-app-jupiter-broadcasting.noarch: I: checking nuvola-app-jupiter-broadcasting.noarch: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-jupiter-broadcasting.noarch: I: checking-url https://github.com/tiliado/nuvola-app-jupiter-broadcasting (timeout 10 seconds) nuvola-app-jupiter-broadcasting.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppJupiterBroadcasting.desktop nuvola the .desktop file is for a file not present in the package. You should check the requires or see if this is not a error 2 packages and 1 specfiles checked; 0 errors, 5 warnings. %changelog * Tue Aug 22 2017 Martin Gansser <martinkg> - 1.1-1 - initial build
Hello, - You should use the %configure macro instead of ./configure --prefix=%{_prefix} - DESTDIR=%{buildroot} is not needed after %make_install - You can actually fix the typo: linux → Linux - Use this for Source0: Source0: https://github.com/tiliado/%{name}/archive/%{version}/%{name}-%{version}.tar.gz
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-jupiter-broadcasting.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-jupiter-broadcasting-1.1-2.fc26.src.rpm %changelog * Wed Aug 23 2017 Martin Gansser <martinkg> - 1.1-2 - use the %%configure macro - DESTDIR=%%{buildroot} is not needed after %%make_install - fix typo - Use correct Source0
All good, package accepted.
Thanks for the review.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-jupiter-broadcasting
package has been built successfully on f25, f26, f27 and rawhide.