Bug 1485389 - Running scriptlet: None
Summary: Running scriptlet: None
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: 26
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-25 14:27 UTC by Viliam Križan
Modified: 2018-04-15 18:11 UTC (History)
12 users (show)

Fixed In Version: rpm-4.13.1-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-15 18:11:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Viliam Križan 2017-08-25 14:27:15 UTC
Description of problem:

First transaction printed by dnf when updating packages is: "Running scriptlet: None"

How reproducible:


Steps to Reproduce:
1. dnf update

Actual results:

~~~
Running transaction
  Running scriptlet: None                                                                                    1/1 
  Preparing        :                                                                                         1/1 
~~~

Expected results:

The message with "None" to be skipped.

Comment 1 Igor Gnatenko 2017-08-30 06:48:36 UTC
Can you re-run it with --rpmverbosity=debug and paste output? It's interesting which scriptlet is running..

Comment 2 Jaroslav Mracek 2017-08-31 08:08:36 UTC
How dnf identify package for scriplets?

rpm callback provide:
1. string with package nevra
2. Object that can be used to find out the package nevra
3. None. In this case dnf can identify object according to running element in transaction, but this approach cannot be applied for the case, because transaction technically didn't start. 

What we can do:
1. in the case report only
"Running scriptlet:"
and not
"Running scriptlet: None"
2. Request for rpm team to always provide package string in callbacks and not None for any cases.

Comment 3 Viliam Križan 2017-08-31 08:46:48 UTC
(In reply to Igor Gnatenko from comment #1)
> Can you re-run it with --rpmverbosity=debug and paste output? It's
> interesting which scriptlet is running..

I am unable to reproduce it for my current state of updated packages. I will keep an eye on the debug output and share it if the issue arises.

Comment 4 Igor Gnatenko 2017-08-31 09:28:16 UTC
Thanks, if you will be able to reproduce it -- please reopen bug with additional details!

Comment 5 Jaroslav Mracek 2017-08-31 09:57:31 UTC
Unfortunately those problems cannot be reproduced, because they appear during performing of transaction, therefore the next transaction handles different packages. Only reverting the last transaction could produce the reproducer, but in Fedora environment, this is quite difficult.

Comment 6 Viliam Križan 2017-09-03 00:17:56 UTC
Reproduced when removing `abrt` package (abrt.x86_64 2.10.3-1.fc26):
~~~
Running transaction
  Running scriptlet: None                                                   1/1 
D: closed   db index       /var/lib/rpm/Packages
D: closed   db index       /var/lib/rpm/Enhancename
D: closed   db index       /var/lib/rpm/Supplementname
D: closed   db index       /var/lib/rpm/Suggestname
D: closed   db index       /var/lib/rpm/Recommendname
D: closed   db index       /var/lib/rpm/Transfiletriggername
D: closed   db index       /var/lib/rpm/Filetriggername
D: closed   db index       /var/lib/rpm/Sha1header
D: closed   db index       /var/lib/rpm/Sigmd5
D: closed   db index       /var/lib/rpm/Installtid
D: closed   db index       /var/lib/rpm/Dirnames
D: closed   db index       /var/lib/rpm/Triggername
D: closed   db index       /var/lib/rpm/Obsoletename
D: closed   db index       /var/lib/rpm/Conflictname
D: closed   db index       /var/lib/rpm/Providename
D: closed   db index       /var/lib/rpm/Requirename
D: closed   db index       /var/lib/rpm/Group
D: closed   db index       /var/lib/rpm/Basenames
D: closed   db index       /var/lib/rpm/Name
D: closed   db environment /var/lib/rpm
D: opening  db environment /var/lib/rpm cdb:0x401
D: opening  db index       /var/lib/rpm/Packages (none) mode=0x42
D: sanity checking 6 elements
D: Plugin: calling hook tsm_pre in selinux plugin
D: Plugin: calling hook tsm_pre in systemd_inhibit plugin
D: System shutdown blocked (fd 20)
D: opening  db index       /var/lib/rpm/Transfiletriggername (none) mode=0x42
D: opening  db index       /var/lib/rpm/Dirnames (none) mode=0x42
D: %triggerun(systemd-233-6.fc26.x86_64): running <lua> scriptlet.
  Preparing        :                                                        1/1ufdio:       2 reads,      957 total 
~~~

Comment 7 Panu Matilainen 2017-09-04 09:44:32 UTC
The problem is that with (file) trigger scriptlets, rpm doesn't always supply a header to the callback because there's no transaction element associated with these items.

Comment 8 Panu Matilainen 2017-09-04 13:39:56 UTC
Oops, wrong take button.

Comment 9 Panu Matilainen 2017-09-04 15:13:43 UTC
The fundamental issue fixed upstream now: https://github.com/rpm-software-management/rpm/commit/6d610e9b9a906548ce44265d7f36199441ea8bca:

[...]
Transaction test succeeded.
Running transaction
  Running scriptlet: systemd                                                1/1 
  Preparing        :                                                        1/1 
  Erasing          : abrt-dbus-2.10.3-1.fc26.x86_64                         1/8 
[...]

There are various related issues due to the limitations of the python binding callback but that's beyond the scope of this bug.

Comment 10 Panu Matilainen 2017-09-07 08:07:15 UTC
Fixed in rawhide now as per above, plus F27 once the beta freeze lifts.

We can consider backporting to older versions later once it's clear there are no unexpected side-effects.

Comment 11 Fedora Update System 2018-03-28 14:13:46 UTC
rpm-4.13.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d4cacdf9bc

Comment 12 Fedora Update System 2018-03-29 00:19:00 UTC
rpm-4.13.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d4cacdf9bc

Comment 13 Fedora Update System 2018-04-15 18:11:50 UTC
rpm-4.13.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.