Bug 149193 - patch for a couple of bugs, some improvements
Summary: patch for a couple of bugs, some improvements
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: policycoreutils
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Walsh
QA Contact: Ben Levenson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-02-20 19:24 UTC by Ulrich Drepper
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version: 1.21.18-2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-04 23:36:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
the mentioned patch (5.75 KB, patch)
2005-02-20 19:24 UTC, Ulrich Drepper
no flags Details | Diff

Description Ulrich Drepper 2005-02-20 19:24:29 UTC
Description of problem:
I'll attach a patch which fixes two real bugs, adds unconditionally compiler
flags to get more warnings, fix the resulting warnings, and optimize a few
binaries by removing unnecessary DSO references.

In detail:

~ The Makefiles should use the -Wall option even if compiled in beehive
~ Add -W, too
~ use -Werror when used outside of beehive.  This could also be used unconditionally
~ setfiles/setfiles.c: fix resulting warning
~ restorecon/restorecon.c: Likewise
~ run_init/open_init_pty.c: argc hasn't been checked, the program would crash if
called without parameters.  ignore the return value of nice properly.
~ run_init: don't link with -ldl lutil
~ load_policy: that's the bad bug.  pointer to unsigned int is passed, size_t is
written to.  fails on 64-bit archs
~ sestatus: signed vs unsigned problem
~ newrole: don't link with -ldl

Version-Release number of selected component (if applicable):
policycoreutils-1.21.18-1

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Ulrich Drepper 2005-02-20 19:24:29 UTC
Created attachment 111242 [details]
the mentioned patch

Comment 2 Daniel Walsh 2005-02-21 14:30:33 UTC
Applied patch in policycoreutils-1.21.18-2

Thanks.


Note You need to log in before you can comment on or make changes to this bug.