Description of problem: I'll attach a patch which fixes two real bugs, adds unconditionally compiler flags to get more warnings, fix the resulting warnings, and optimize a few binaries by removing unnecessary DSO references. In detail: ~ The Makefiles should use the -Wall option even if compiled in beehive ~ Add -W, too ~ use -Werror when used outside of beehive. This could also be used unconditionally ~ setfiles/setfiles.c: fix resulting warning ~ restorecon/restorecon.c: Likewise ~ run_init/open_init_pty.c: argc hasn't been checked, the program would crash if called without parameters. ignore the return value of nice properly. ~ run_init: don't link with -ldl lutil ~ load_policy: that's the bad bug. pointer to unsigned int is passed, size_t is written to. fails on 64-bit archs ~ sestatus: signed vs unsigned problem ~ newrole: don't link with -ldl Version-Release number of selected component (if applicable): policycoreutils-1.21.18-1 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 111242 [details] the mentioned patch
Applied patch in policycoreutils-1.21.18-2 Thanks.