Bug 1496491 - Review Request: perl-IO-Socket-SSL - Perl library for transparent SSL
Summary: Review Request: perl-IO-Socket-SSL - Perl library for transparent SSL
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora Modules
Classification: Fedora
Component: Module Review
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1876866 (view as bug list)
Depends On:
Blocks: 1881451
TreeView+ depends on / blocked
 
Reported: 2017-09-27 15:02 UTC by Jitka Plesnikova
Modified: 2020-09-22 12:15 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-05 14:19:29 UTC
Type: Bug
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2017-09-27 15:02:22 UTC
Modulemd URL: https://jplesnik.fedorapeople.org/modules/perl-IO-Socket-SSL.yaml
Description:
        This module is a true drop-in replacement for IO::Socket::INET that
        uses SSL to encrypt data before it is transferred to a remote
        server or client. IO::Socket::SSL supports all the extra features
        that one needs to write a full-featured SSL client or server
        application: multiple SSL contexts, cipher selection, certificate
        verification, and SSL version selection. As an extra bonus, it
        works perfectly with mod_perl.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2017-10-02 08:26:03 UTC
The module does not provide packages already existing in different module. Ok.
Summary is Ok.

TODO: The description should describe the Modularity module. Not one of the Perl modules delivered by the Modularity modules. I.e. copying perl-IO-Socket-SSL description is probably not the right thing to do. However, if you want to ignore the Net::SSLeay completely, then probably perl-IO-Socket-SSL description is fine.

License is Ok.
Build and run-time dependencies are Ok.

TODO: I recomment to add a comment to the build-dependency on host:master that this is not a real dependency but rather a workaround for current infrastructure so that you don't forget to remove it when possible.

The profiles, api, filter are Ok.
The component list is Ok.

I verified the components have satisfied build-time dependencies.

Otherwise this module is in line with Module packaging guidelines.

Please consider fixing the `TODO' item before building this module.
Resolution: Module APPROVED.

Comment 2 Gwyn Ciesla 2017-10-05 12:38:16 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/modules/perl-IO-Socket-SSL

Comment 3 Jitka Plesnikova 2017-10-05 14:19:29 UTC
Thank you for the review and the repository.

Comment 4 Petr Pisar 2020-09-09 06:54:14 UTC
*** Bug 1876866 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.