Bug 149711 - five buglets
five buglets
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: glunarclock (Show other bugs)
3
All Linux
medium Severity medium
: ---
: ---
Assigned To: Orphan Owner
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-02-25 12:56 EST by David Binderman
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-07-24 19:16:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description David Binderman 2005-02-25 12:56:46 EST
Description of problem:

I just tried to compile package glunarclock-0.32.2-2 from 
Redhat Fedora Extras development tree.

The compiler said

1.

glunarclock.c(162): warning #1011: missing return statement at end of
non-void function "delete_event"
glunarclock.c(169): warning #1011: missing return statement at end of
non-void function "close_dialog"

THe source code is

static gboolean
delete_event (GtkWidget  *widget,
              MoonApplet *moon)
{
        gtk_widget_hide (widget);
}

static gboolean
close_dialog (GtkWidget  *widget,
              MoonApplet *moon)
{
        gtk_widget_hide (moon->preferences_dialog);
}

There might be some value in adding a couple of return statements
to these functions.

2.

moondata.c(227): warning #1011: missing return statement at end of
non-void function "delete_event"
moondata.c(234): warning #1011: missing return statement at end of
non-void function "close_data_dialog"

Duplicates.

3.

moondata.c(286): warning #269: invalid format string conversion

The source code is

        g_snprintf(buf, size, "%2d%",(gint)(moondata.NewMoon));

Suggest use %% for % in printf strings.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Michael Schwendt 2005-07-24 19:16:43 EDT
Fixed in CVS.
Forwarded upstream.

Note You need to log in before you can comment on or make changes to this bug.