Bug 150012 - 2 * undefined code
Summary: 2 * undefined code
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-String-Ediff
Version: 3
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-03-01 17:04 UTC by David Binderman
Modified: 2007-11-30 22:11 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2005-03-10 16:06:02 UTC


Attachments (Terms of Use)

Description David Binderman 2005-03-01 17:04:02 UTC
Description of problem:

I just tried to compile package perl-String-Ediff-0.04-1 from 
Redhat Fedora Extras development tree.

The compiler said

1.

st.c:142: warning: operation on `i' may be undefined

The source code is

    i = ++i % t->m_hash_base;

I agree with the compiler - the code certainly is undefined.
Suggest

    i = (i + 1) % t->m_hash_base;

2.

st.c:163: warning: operation on `i' may be undefined

Duplicate.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Ville Skyttä 2005-03-10 16:06:02 UTC
Should be fixed in 0.05-1.


Note You need to log in before you can comment on or make changes to this bug.