Bug 1500831 - Review Request: douceur - A simple CSS parser and inliner in Go
Summary: Review Request: douceur - A simple CSS parser and inliner in Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1500821 1500828
Blocks: 1500574
TreeView+ depends on / blocked
 
Reported: 2017-10-11 14:52 UTC by Athos Ribeiro
Modified: 2017-11-11 02:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-11-11 02:53:27 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Athos Ribeiro 2017-10-11 14:52:03 UTC
Spec URL: https://athoscr.fedorapeople.org/packaging/douceur.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/douceur-0.2.0-1.fc26.src.rpm
Description: A simple CSS parser and inliner in Go
Fedora Account System Username: athoscr

Comment 1 Robert-André Mauchin 🐧 2017-10-12 08:23:34 UTC
A dependency is missing:

DEBUG util.py:458:    - nothing provides golang(github.com/andybalholm/cascadia) needed by golang-github-PuerkitoBio-goquery-devel-1.1.0-1.fc28.noarch

Comment 2 Robert-André Mauchin 🐧 2017-10-12 08:36:21 UTC
Oops disregard the previous message.

  - There's an error in the Requires of unit-test-devel:

%if 0%{?with_unit_test} && 0%{?with_devel}
%package -n golang-%{provider}-%{project}-%{repo}-unit-test-devel
Summary:         Unit tests for %{name} package
%if 0%{?with_check}
#Here comes all BuildRequires: PACKAGE the unit tests
#in %%check section need for running
%endif

# test subpackage tests code from devel subpackage
Requires:        %{name}-devel = %{version}-%{release}


   %{name}-devel will be replaced by douceur-devel which doesn't exist. It should be:

Requires:        golang-%{provider}-%{project}-%{repo}-devel = %{version}-%{release}

Comment 3 Athos Ribeiro 2017-10-12 17:42:13 UTC
Hi Robert, Thanks for the input here.

I did let that one pass, sorry for that. There you go:

Spec URL: https://athoscr.fedorapeople.org/packaging/douceur.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/douceur-0.2.0-2.fc26.src.rpm

Comment 4 Robert-André Mauchin 🐧 2017-10-12 18:06:46 UTC
Package accepted.

Comment 5 Athos Ribeiro 2017-10-13 20:45:57 UTC
Thanks for the review!!!

Comment 6 Gwyn Ciesla 2017-10-13 21:41:08 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/douceur

Comment 7 Fedora Update System 2017-10-14 18:32:31 UTC
douceur-0.2.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7ae434fd66

Comment 8 Fedora Update System 2017-10-15 05:53:27 UTC
douceur-0.2.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7ae434fd66

Comment 9 Fedora Update System 2017-11-11 02:53:27 UTC
douceur-0.2.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.