Bug 1501236 - Grub2-prode failed to find the disk on LVM
Summary: Grub2-prode failed to find the disk on LVM
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: imgbased
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.3.0
: ---
Assignee: Yuval Turgeman
QA Contact: Qin Yuan
URL:
Whiteboard:
Depends On: 1515338
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-12 09:08 UTC by Yihui Zhao
Modified: 2022-03-13 14:37 UTC (History)
11 users (show)

Fixed In Version: imgbased-1.1.3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-13 07:45:11 UTC
oVirt Team: Node
Embargoed:
rule-engine: ovirt-4.3+
cshao: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-45180 0 None None None 2022-03-13 14:37:27 UTC
oVirt gerrit 96339 0 master MERGED osupdater: disable grub os probes 2021-02-18 02:07:57 UTC

Description Yihui Zhao 2017-10-12 09:08:27 UTC
Description of problem:
Grub2-prode  failed to find the disk on LVM.

Version-Release number of selected component (if applicable):
redhat-virtualization-host-4.2-20171011.2
cockpit-system-151-1.el7.noarch
cockpit-ws-151-1.el7.x86_64
cockpit-storaged-151-1.el7.noarch
cockpit-ovirt-dashboard-0.11.0-0.0.3.el7ev.noarch
cockpit-bridge-151-1.el7.x86_64
grub2-tools-minimal-2.02-0.64.el7.x86_64
grub2-pc-modules-2.02-0.64.el7.noarch
grub2-tools-2.02-0.64.el7.x86_64
grub2-pc-2.02-0.64.el7.x86_64
grubby-8.28-23.el7.x86_64
grub2-tools-extra-2.02-0.64.el7.x86_64
grub2-efi-x64-2.02-0.64.el7.x86_64
grub2-common-2.02-0.64.el7.noarch
grub2-2.02-0.64.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Clean install redhat-virtualization-host-4.2-20171011.2
2. Open the iommu, edit the file "/etc/default/grub", add the parameter “intel_iommu=on" in "GRUB_CMDLINE)LINUX" line

[root@dhcp-10-244 ~]# cat /etc/default/grub 
GRUB_TIMEOUT=5
GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
GRUB_DEFAULT=saved
GRUB_DISABLE_SUBMENU=true
GRUB_TERMINAL_OUTPUT="console"
GRUB_CMDLINE_LINUX='crashkernel=auto rd.lvm.lv=rhvh_dhcp-10-244/rhvh-4.2-0.20171012.0+1 rd.lvm.lv=rhvh_dhcp-10-244/swap rhgb quiet intel_iommu=on'
GRUB_DISABLE_RECOVERY="true"

3. Update the grub:
[root@dhcp-10-244 ~]# grub2-mkconfig -o /boot/grub2/grub.cfg

4. Check the iommu is on:
#cat /etc/proc/cmdline


Actual results:
1. After step 3, grub2-probe failed to find the disk on LVM

[root@dhcp-10-244 ~]# grub2-mkconfig -o /boot/grub2/grub.cfg
Generating grub configuration file ...
Found linux image: /boot/rhvh-4.2-0.20171012.0+1//vmlinuz-3.10.0-693.2.2.el7.x86_64
Found initrd image: /boot/rhvh-4.2-0.20171012.0+1/initramfs-3.10.0-693.2.2.el7.x86_64.img
Found linux image: /boot/vmlinuz-3.10.0-693.2.2.el7.x86_64
Found initrd image: /boot/initramfs-3.10.0-693.2.2.el7.x86_64.img
Found linux image: /boot/vmlinuz-3.10.0-693.2.2.el7.x86_64
Found initrd image: /boot/initramfs-3.10.0-693.2.2.el7.x86_64.img
/usr/sbin/grub2-probe: error: disk `lvmid/LtygRu-Xsn7-UwAz-90Nd-ccIe-RNBl-bS9HhL/yBqS15-XJXO-5buv-pxPc-W1AR-a816-QPkmN9' not found.
Found Red Hat Enterprise Linux release 7.4 on /dev/mapper/rhvh_dhcp--10--244-root
done

2. After step 4, iommu isn't on.

Expected results:
1. After step3, grub2-probe can find the disk on LVM
2. After step4, iommu is on.


Additional info:
1. 
[root@dhcp-10-244 ~]# mount
sysfs on /sys type sysfs (rw,nosuid,nodev,noexec,relatime,seclabel)
proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
devtmpfs on /dev type devtmpfs (rw,nosuid,seclabel,size=7997440k,nr_inodes=1999360,mode=755)
securityfs on /sys/kernel/security type securityfs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /dev/shm type tmpfs (rw,nosuid,nodev,seclabel)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,seclabel,gid=5,mode=620,ptmxmode=000)
tmpfs on /run type tmpfs (rw,nosuid,nodev,seclabel,mode=755)
tmpfs on /sys/fs/cgroup type tmpfs (ro,nosuid,nodev,noexec,seclabel,mode=755)
cgroup on /sys/fs/cgroup/systemd type cgroup (rw,nosuid,nodev,noexec,relatime,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd)
pstore on /sys/fs/pstore type pstore (rw,nosuid,nodev,noexec,relatime)
cgroup on /sys/fs/cgroup/cpu,cpuacct type cgroup (rw,nosuid,nodev,noexec,relatime,cpuacct,cpu)
cgroup on /sys/fs/cgroup/net_cls,net_prio type cgroup (rw,nosuid,nodev,noexec,relatime,net_prio,net_cls)
cgroup on /sys/fs/cgroup/hugetlb type cgroup (rw,nosuid,nodev,noexec,relatime,hugetlb)
cgroup on /sys/fs/cgroup/pids type cgroup (rw,nosuid,nodev,noexec,relatime,pids)
cgroup on /sys/fs/cgroup/cpuset type cgroup (rw,nosuid,nodev,noexec,relatime,cpuset)
cgroup on /sys/fs/cgroup/blkio type cgroup (rw,nosuid,nodev,noexec,relatime,blkio)
cgroup on /sys/fs/cgroup/devices type cgroup (rw,nosuid,nodev,noexec,relatime,devices)
cgroup on /sys/fs/cgroup/memory type cgroup (rw,nosuid,nodev,noexec,relatime,memory)
cgroup on /sys/fs/cgroup/perf_event type cgroup (rw,nosuid,nodev,noexec,relatime,perf_event)
cgroup on /sys/fs/cgroup/freezer type cgroup (rw,nosuid,nodev,noexec,relatime,freezer)
configfs on /sys/kernel/config type configfs (rw,relatime)
/dev/mapper/rhvh_dhcp--10--244-rhvh--4.2--0.20171012.0+1 on / type ext4 (rw,relatime,seclabel,discard,stripe=16,data=ordered)
selinuxfs on /sys/fs/selinux type selinuxfs (rw,relatime)
systemd-1 on /proc/sys/fs/binfmt_misc type autofs (rw,relatime,fd=35,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=13141)
hugetlbfs on /dev/hugepages1G type hugetlbfs (rw,relatime,seclabel,pagesize=1G)
debugfs on /sys/kernel/debug type debugfs (rw,relatime)
hugetlbfs on /dev/hugepages type hugetlbfs (rw,relatime,seclabel)
mqueue on /dev/mqueue type mqueue (rw,relatime,seclabel)
nfsd on /proc/fs/nfsd type nfsd (rw,relatime)
/dev/sda1 on /boot type ext4 (rw,relatime,seclabel,data=ordered)
/dev/mapper/rhvh_dhcp--10--244-tmp on /tmp type ext4 (rw,relatime,seclabel,discard,stripe=16,data=ordered)
/dev/mapper/rhvh_dhcp--10--244-var on /var type ext4 (rw,relatime,seclabel,discard,stripe=16,data=ordered)
/dev/mapper/rhvh_dhcp--10--244-home on /home type ext4 (rw,relatime,seclabel,discard,stripe=16,data=ordered)
/dev/mapper/rhvh_dhcp--10--244-var_crash on /var/crash type ext4 (rw,relatime,seclabel,discard,stripe=16,data=ordered)
/dev/mapper/rhvh_dhcp--10--244-var_log on /var/log type ext4 (rw,relatime,seclabel,discard,stripe=16,data=ordered)
/dev/mapper/rhvh_dhcp--10--244-var_log_audit on /var/log/audit type ext4 (rw,relatime,seclabel,discard,stripe=16,data=ordered)
sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw,relatime)
tmpfs on /run/user/0 type tmpfs (rw,nosuid,nodev,relatime,seclabel,size=1605496k,mode=700)
fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)


2.
[root@dhcp-10-244 ~]# lsblk
NAME                                                 MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
sda                                                    8:0    0 465.8G  0 disk 
├─sda1                                                 8:1    0     1G  0 part /boot
└─sda2                                                 8:2    0 464.8G  0 part 
  ├─rhvh_dhcp--10--244-pool00_tmeta                  253:0    0     1G  0 lvm  
  │ └─rhvh_dhcp--10--244-pool00-tpool                253:2    0 363.7G  0 lvm  
  │   ├─rhvh_dhcp--10--244-rhvh--4.2--0.20171012.0+1 253:3    0 336.7G  0 lvm  /
  │   ├─rhvh_dhcp--10--244-pool00                    253:5    0 363.7G  0 lvm  
  │   ├─rhvh_dhcp--10--244-var_log_audit             253:6    0     2G  0 lvm  /var/log/audit
  │   ├─rhvh_dhcp--10--244-var_log                   253:7    0     8G  0 lvm  /var/log
  │   ├─rhvh_dhcp--10--244-var                       253:8    0    15G  0 lvm  /var
  │   ├─rhvh_dhcp--10--244-tmp                       253:9    0     1G  0 lvm  /tmp
  │   ├─rhvh_dhcp--10--244-home                      253:10   0     1G  0 lvm  /home
  │   ├─rhvh_dhcp--10--244-root                      253:11   0 336.7G  0 lvm  
  │   └─rhvh_dhcp--10--244-var_crash                 253:12   0    10G  0 lvm  /var/crash
  ├─rhvh_dhcp--10--244-pool00_tdata                  253:1    0 363.7G  0 lvm  
  │ └─rhvh_dhcp--10--244-pool00-tpool                253:2    0 363.7G  0 lvm  
  │   ├─rhvh_dhcp--10--244-rhvh--4.2--0.20171012.0+1 253:3    0 336.7G  0 lvm  /
  │   ├─rhvh_dhcp--10--244-pool00                    253:5    0 363.7G  0 lvm  
  │   ├─rhvh_dhcp--10--244-var_log_audit             253:6    0     2G  0 lvm  /var/log/audit
  │   ├─rhvh_dhcp--10--244-var_log                   253:7    0     8G  0 lvm  /var/log
  │   ├─rhvh_dhcp--10--244-var                       253:8    0    15G  0 lvm  /var
  │   ├─rhvh_dhcp--10--244-tmp                       253:9    0     1G  0 lvm  /tmp
  │   ├─rhvh_dhcp--10--244-home                      253:10   0     1G  0 lvm  /home
  │   ├─rhvh_dhcp--10--244-root                      253:11   0 336.7G  0 lvm  
  │   └─rhvh_dhcp--10--244-var_crash                 253:12   0    10G  0 lvm  /var/crash
  └─rhvh_dhcp--10--244-swap                          253:4    0   7.8G  0 lvm  [SWAP]
sr0                                                   11:0    1  1024M  0 rom

Comment 1 Yihui Zhao 2017-10-17 10:11:18 UTC
Update:
Today I tested on rhvh 4.1.7, also has the issue.

Test version:
rhvh-4.1-0.20171012.0+1
grub2-tools-minimal-2.02-0.64.el7.x86_64
grub2-tools-2.02-0.64.el7.x86_64
grubby-8.28-23.el7.x86_64
grub2-2.02-0.64.el7.x86_64
grub2-pc-modules-2.02-0.64.el7.noarch
grub2-tools-extra-2.02-0.64.el7.x86_64
grub2-pc-2.02-0.64.el7.x86_64
grub2-common-2.02-0.64.el7.noarch
grub2-efi-x64-2.02-0.64.el7.x86_64


Test steps:
The same as the bug description.

Test results:
After step3,

[root@dhcp-10-244 ~]# grub2-mkconfig -o /boot/grub2/grub.cfg
Generating grub configuration file ...
Found linux image: /boot/rhvh-4.1-0.20171012.0+1//vmlinuz-3.10.0-693.2.2.el7.x86_64
Found initrd image: /boot/rhvh-4.1-0.20171012.0+1/initramfs-3.10.0-693.2.2.el7.x86_64.img
Found linux image: /boot/vmlinuz-3.10.0-693.2.2.el7.x86_64
Found initrd image: /boot/initramfs-3.10.0-693.2.2.el7.x86_64.img
Found linux image: /boot/vmlinuz-3.10.0-693.2.2.el7.x86_64
Found initrd image: /boot/initramfs-3.10.0-693.2.2.el7.x86_64.img
/usr/sbin/grub2-probe: error: disk `lvmid/OGUMef-JChs-UTC8-bdLs-ViIE-cT1N-HVy0xv/LBREd5-hzHX-jt94-Wqj0-xL24-C2YD-FhO12I' not found.
Found Red Hat Enterprise Linux release 7.4 on /dev/mapper/rhvh_dhcp--10--244-root
done

Comment 2 Ryan Barry 2017-10-17 23:39:43 UTC
I can't reproduce this.

I do see the message from grub2-probe (the uuid on my system is the VG itself, not the LV, which may be a grub2 bug), but the generated config file is correct, and intel_iommu is present.

Can you provide a test system? Are you sure the generated config file is not actually correct?

Or, failing that, simply try:

grub2-mkconfig | less

Search for 09_node and look at the generated cmdline. I'd expect intel_iommu to be present.

Test steps below:

# grub2-mkconfig -o test       
Generating grub configuration file ...           
Found linux image: /boot/rhvh-4.2-0.20171012.0+1//vmlinuz-3.10.0-693.2.2.el7.x86_64                
Found initrd image: /boot/rhvh-4.2-0.20171012.0+1/initramfs-3.10.0-693.2.2.el7.x86_64.img          
Found linux image: /boot/vmlinuz-3.10.0-693.2.2.el7.x86_64                                         
Found initrd image: /boot/initramfs-3.10.0-693.2.2.el7.x86_64.img                                  
Found linux image: /boot/vmlinuz-3.10.0-693.2.2.el7.x86_64                                         
Found initrd image: /boot/initramfs-3.10.0-693.2.2.el7.x86_64.img                                  
/usr/sbin/grub2-probe: error: disk `lvmid/4EmcYv-Bmps-Wc3u-bI5m-5mZs-PLom-zIVWZk/y0cnV4-Dv3K-Pept-4rLE-dSjX-bc9o-0kXy4Z' not found.                                                                   
Found Red Hat Enterprise Linux release 7.4 on /dev/mapper/rhvh-root                                
done             

# cat test
...
### BEGIN /etc/grub.d/09_node ###                                                                                                                                                                     
menuentry 'rhvh-4.2-0.20171012.0+1' --class red --class gnu-linux --class gnu --class os --unrestricted $menuentry_id_option 'gnulinux-3.10.0-693.2.2.el7.x86_64-advanced-/dev/mapper/rhvh-rhvh--4.2--
0.20171012.0+1' {                                                                                                                                                                                     
   load_video                                                                                                                                                                                         
    set gfxpayload=keep                                                                                                                                                                               
    insmod gzio                                                                                                                                                                                       
        insmod part_msdos                                                                                                                                                                             
        insmod ext2                                                                                                                                                                                   
        set root='hd0,msdos1'                                                                                                                                                                         
        if [ x$feature_platform_search_hint = xy ]; then                                                                                                                                              
          search --no-floppy --fs-uuid --set=root --hint-bios=hd0,msdos1 --hint-efi=hd0,msdos1 --hint-baremetal=ahci0,msdos1 --hint='hd0,msdos1'  7da03143-7e25-4c46-92af-ccf3f8732aed                
        else                                                                                                                                                                                          
          search --no-floppy --fs-uuid --set=root 7da03143-7e25-4c46-92af-ccf3f8732aed                                                                                                                
        fi                                                                                                                                                                                            
       linux16 /rhvh-4.2-0.20171012.0+1/vmlinuz-3.10.0-693.2.2.el7.x86_64 root=/dev/rhvh/rhvh-4.2-0.20171012.0+1 ro crashkernel=auto  rd.lvm.lv=rhvh/swap rhgb quiet intel_iommu=on rd.lvm.lv=rhvh/rhv
h-4.2-0.20171012.0+1 img.bootid=rhvh-4.2-0.20171012.0+1                                                                                                                                               
       initrd16 /rhvh-4.2-0.20171012.0+1/initramfs-3.10.0-693.2.2.el7.x86_64.img                                                                                                                      
}                                                                                                                                                                                                     
                                                                                                                                                                                                      
### END /etc/grub.d/09_node ###  
...

Comment 3 Ryan Barry 2017-10-17 23:41:01 UTC
Note that the warning from grub2-probe has been present since at least 4.1.3-1 (the earliest image I tested).

This bug does not appear to be new.

Comment 5 Ryan Barry 2017-10-19 13:22:20 UTC
Ok. Since this has no functional impact, I'll file a platform bug to track the debug message.

Comment 7 Qin Yuan 2019-01-21 10:36:20 UTC
Tested with:
redhat-virtualization-host-4.3-20190116.0
imgbased-1.1.3-0.1.el7ev.noarch

There is no grub2-probe error:
[root@ati_local_02 ~]# grub2-mkconfig -o /boot/grub2/grub.cfg
Generating grub configuration file ...
Found linux image: /boot/rhvh-4.3.0.2-0.20190116.0+1//vmlinuz-3.10.0-957.1.3.el7.x86_64
Found initrd image: /boot/rhvh-4.3.0.2-0.20190116.0+1/initramfs-3.10.0-957.1.3.el7.x86_64.img
Found linux image: /boot/vmlinuz-3.10.0-957.1.3.el7.x86_64
Found initrd image: /boot/initramfs-3.10.0-957.1.3.el7.x86_64.img
done

The bug is fixed, change status to VERIFIED.

Comment 8 Sandro Bonazzola 2019-02-13 07:45:11 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.