Bug 1517099 - Review Request: perl-Export-Attrs - The Perl 6 'is export(...)' trait as a Perl 5 attribute
Summary: Review Request: perl-Export-Attrs - The Perl 6 'is export(...)' trait as a Pe...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1517102
TreeView+ depends on / blocked
 
Reported: 2017-11-24 08:22 UTC by Emmanuel Seyman
Modified: 2017-12-12 13:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-12 11:18:20 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2017-11-24 08:22:20 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Export-Attrs/perl-Export-Attrs.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Export-Attrs/perl-Export-Attrs-0.1.0-1.fc26.src.rpm
Description:
This module is a fork of Perl6::Export::Attrs created to restore
compatibility with Perl6::Export::Attrs version 0.0.3.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2017-11-24 14:56:34 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
TODO: Constrain `perl(Module::Build::Tiny)' dependency with `>= 0.034' (Build.PL:5).
TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.41' (t/author-pod-syntax.t:12).

$ rpm -qp --requires perl-Export-Attrs-0.1.0-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Attribute::Handlers)
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(PadWalker)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Export-Attrs-0.1.0-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Export::Attrs) = 0.1.0
      1 perl-Export-Attrs = 0.1.0-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Export-Attrs*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please consider fixing 'TODO' items.

The package looks good.
Approved

Comment 2 Emmanuel Seyman 2017-11-24 21:49:43 UTC
(In reply to Jitka Plesnikova from comment #1)
>
> TODO: Constrain `perl(Module::Build::Tiny)' dependency with `>= 0.034'
> (Build.PL:5).
> TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.41'
> (t/author-pod-syntax.t:12).

Done. I've also activated the release distribution test (via RELEASE_TESTING=1) and included perl(Test::Distribution) as a build requirement.

> The package looks good.
> Approved

Repo requested. Thanks for the review.

Comment 3 Gwyn Ciesla 2017-11-27 14:13:03 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Export-Attrs

Comment 4 Fedora Update System 2017-11-27 19:45:33 UTC
perl-Export-Attrs-0.1.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9d2073f27a

Comment 5 Fedora Update System 2017-11-27 19:45:42 UTC
perl-Export-Attrs-0.1.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ca2b0575b

Comment 6 Fedora Update System 2017-11-28 06:46:48 UTC
perl-Export-Attrs-0.1.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9d2073f27a

Comment 7 Fedora Update System 2017-11-28 07:25:06 UTC
perl-Export-Attrs-0.1.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ca2b0575b

Comment 8 Fedora Update System 2017-12-12 11:18:20 UTC
perl-Export-Attrs-0.1.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-12-12 13:41:13 UTC
perl-Export-Attrs-0.1.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.